-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add read only mount support #41
Conversation
Hey @tehcyx, anything else I need to do for this PR? Really appreciate your work on this provider! |
Hi @JackFlukinger, no you're good. Just haven't gotten around testing this. Doing that now, as well as running tests on the PR. |
Ah, I do see one small problem now that I look back. Oops! Fixing & committing now |
So what I found is, that we should change the function like this:
Since we already have the mapping done: edit: Actually you uncovered that I missed adding three options here to the mapping. |
Yeah, I just saw that, I think read_only is more idiomatic. I'll add propagation & selinux_relable real quick |
True. Thanks for adding the other two. |
Cool, done, let me know if that looks all good to you :) |
Testing, then probably merging if nothing pops up. |
No description provided.