Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout in getc should be treated as a NAK and cause a resend #12

Merged
merged 1 commit into from
Mar 17, 2015
Merged

Timeout in getc should be treated as a NAK and cause a resend #12

merged 1 commit into from
Mar 17, 2015

Conversation

jkflying
Copy link
Contributor

This change allowed 1k mode to successfully load to a Sierra Wireless SL6087, with mode='xmodem1k' and pad='\xff'

@jkflying
Timeout in getc should be treated as a NAK and cause a resend
5590672 
This change allowed 1k mode to successfully load to a Sierra Wireless SL6087, with mode='xmodem1k' and pad='\xff'
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.32% when pulling 5590672 on jkflying:master into 3d7fbfa on tehmaze:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 63.26% when pulling 5590672 on jkflying:master into 3d7fbfa on tehmaze:master.

@jquast jquast added the bug label Mar 13, 2015
@jquast jquast self-assigned this Mar 13, 2015
@jquast jquast mentioned this pull request Mar 13, 2015
Merged
@jquast
Copy link
Collaborator

jquast commented Mar 13, 2015

Folded into PR #13 for release

@tehmaze tehmaze merged commit 5590672 into tehmaze:master Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jquast jquast

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkflying @landscape-bot @coveralls @jquast @tehmaze