Bugfix block persisting retry #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… documentation Previously 'retry' parameter match the absolute number of resend before failing. With the fix 'retry' match the maximum number of resend a failed packet before failing
In many of these cases, 'error_count' is incremented before being compared to retry, so, where error_count is 0 and retry is 1, the expression: error_count += 1 if error_count >= retry: (...) would always evaluate, and never retry as intended
We should always chose to test on the edge of any numeric boundaries whenever they are identified as a given. In this case, by ensuring we always retry minimally 1 time, we discovered another bug (fixed by previous commit), where retry=1 would never retry, exposing an off-by-1 count.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repeat's @ferboz's PR #21, with changelog, version bump, tests cleanup.
... and an additional minor bugfix! (documented in changelog of README.rst) horay for tests.