encodeURI the profile name in the link #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Probably we also need to add it to the username link on the threads |
|
What does encodeURI does on ❯ node
Welcome to Node.js v20.9.0.
Type ".help" for more information.
> encodeURI("Jim")
'Jim'
> encodeURI("/Jim")
'/Jim' |
That subjkt has a trailing space, so it's actually |
OMG 🤣 |
melMass
approved these changes
Nov 10, 2023
|
Feel free to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jagracar found that the profile link on https://teia.art/objkt/839464/history doesn't work, however the on in history does. I compared the 2 hrefs and found that the history one gets
encodeURI()'d while the other one doesn't.You get "user not found" instead
