Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an ipfs gateway selector to the settings #380

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Zir0h
Copy link
Contributor

@Zir0h Zir0h commented Feb 4, 2024

Possible fix for #294

I think I do too much useLocalSettings.getState().getIpfsGateway() copy/pasting 😅

Copy link

github-actions bot commented Feb 4, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://teia-community.github.io/teia-ui/previews/pr-380/
on branch gh-pages at 2024-04-19 09:42 UTC

@melMass melMass added the 🧪 needs testing Edits that require further "manual" testing label Feb 26, 2024
@Zir0h
Copy link
Contributor Author

Zir0h commented Feb 26, 2024

Doesn't work for me anymore, I did an npm ci; npm start and cleared my browser cache. When I open the main page I see errors in the console, but the page loads fine:
2024-02-26-173228_2818x1203_scrot

Then if I go to the settings page and change the gateway, I get this error:
2024-02-26-173304_2658x1359_scrot

Github actions preview also fails for me, but with t is undefined 🤔

It's also possible that these errors mean nothing and it's the framework trying to figure stuff out 😅

not allowed here
@melMass
Copy link
Member

melMass commented Feb 28, 2024

The last commit should fix the issue, I want to refactor the logic a bit, it's simpler to do it now since it involves a few files. I should have time on wednesday.

@Zir0h
Copy link
Contributor Author

Zir0h commented Mar 2, 2024

The last commit should fix the issue, I want to refactor the logic a bit, it's simpler to do it now since it involves a few files. I should have time on wednesday.

yep, working again! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 needs testing Edits that require further "manual" testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants