Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow visitors to opt-out of the thumbnailing proxy #381

Merged
merged 5 commits into from
Feb 25, 2024

Conversation

Zir0h
Copy link
Contributor

@Zir0h Zir0h commented Feb 4, 2024

I've seen some people dislike the imgproxy thumbnails, because "they are too centralized". With this pull request the visitors can choose to opt-out of using imgproxy and load full-size artifacts directly from ipfs.

Copy link

github-actions bot commented Feb 4, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-25 19:07 UTC

@melMass
Copy link
Member

melMass commented Feb 5, 2024

@melMass
Copy link
Member

melMass commented Feb 5, 2024

Great!
Maybe this click to disable imgproxy thumbnails and load fullsize images instead (performance penalty) could specify directly from IPFS or something similar

@Zir0h
Copy link
Contributor Author

Zir0h commented Feb 5, 2024

I updated the message. I never see it tough 😅 chromium + firefox on linux, I hover over the checkbox and nothing pops up.

@melMass
Copy link
Member

melMass commented Feb 24, 2024

I updated the message. I never see it tough 😅 chromium + firefox on linux, I hover over the checkbox and nothing pops up.

As you now know it's title 😄

@Zir0h
Copy link
Contributor Author

Zir0h commented Feb 24, 2024

I updated the message. I never see it tough 😅 chromium + firefox on linux, I hover over the checkbox and nothing pops up.

As you now know it's title 😄

thank you! 🤣 <3

@melMass melMass merged commit 0bc7d0a into main Feb 25, 2024
3 checks passed
@melMass melMass deleted the feat-add-option-to-disable-imgproxy-thumbnails branch February 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants