Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: frontend #2

Merged
merged 20 commits into from
Sep 24, 2022
Merged

feat: frontend #2

merged 20 commits into from
Sep 24, 2022

Conversation

elianiva
Copy link
Member

No description provided.

@elianiva elianiva added the enhancement New feature or request label Sep 22, 2022
@elianiva elianiva self-assigned this Sep 22, 2022
@elianiva elianiva changed the title [WIP] feat: frontend feat: frontend Sep 22, 2022
@elianiva
Copy link
Member Author

dockerfilenya belum ding, ntaran deh

@aldy505
Copy link
Member

aldy505 commented Sep 22, 2022

sebenernya gw pengen fokus ini jadi bahasa indonesia aja. any chance to support i18n? kalo nggak kita full bahasa indonesia aja.

@elianiva
Copy link
Member Author

oke, tar aku jadiin bahasa Indonesia aja
males banget mau ngerjain i18n

Copy link
Member

@aldy505 aldy505 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kurang dockerfile

frontend/src/components/label/label.tsx Outdated Show resolved Hide resolved
frontend/src/routes/index.tsx Show resolved Hide resolved
@elianiva
Copy link
Member Author

elianiva commented Sep 22, 2022

eh, faviconnya belom diganti ding, sama SEO stuff belom keurus

@aldy505
Copy link
Member

aldy505 commented Sep 22, 2022

@elianiva docker pake bullseye aja. terus tambahin "apt install -y curl"

@aldy505
Copy link
Member

aldy505 commented Sep 22, 2022

@ii64 mau review frontend? wkwkwk

@ii64
Copy link
Collaborator

ii64 commented Sep 22, 2022

Let's try, haven't touch frontend for a while lol

frontend/src/components/header/header.tsx Outdated Show resolved Hide resolved
frontend/src/components/router-head/router-head.tsx Outdated Show resolved Hide resolved
frontend/src/routes/layout.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
frontend/Dockerfile Outdated Show resolved Hide resolved
@aldy505 aldy505 requested a review from ii64 September 23, 2022 03:20
@elianiva elianiva mentioned this pull request Sep 23, 2022
@aldy505 aldy505 merged commit 429f6a9 into master Sep 24, 2022
@aldy505 aldy505 deleted the feat/frontend branch September 24, 2022 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants