feat(backend): list languages #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ii64 gw ada pindahin urutan buat structnya biar di define di atas semua. ini dibawah karena bekas yang lama, sebelomnya dia ngga pake struct+impl, tapi pure pub fn, dan struct buat response dari githubnya gw bikin diatas masing-masing function. |
elianiva
reviewed
Sep 22, 2022
backend/src/github.rs
Outdated
Comment on lines
126
to
131
| let mut clean_issues: Vec<Issue> = vec![]; | ||
| for issue in json_response { | ||
| if !issue.node_id.starts_with("PR_") { | ||
| clean_issues.push(issue); | ||
| } | ||
| } |
There was a problem hiding this comment.
pake filter dong biar ganteng xixixi
backend/src/github.rs
Outdated
Comment on lines
145
to
164
| let mut language_set: Vec<(String, i64)> = vec![]; | ||
|
|
||
| for (key, value) in &json_response { | ||
| language_set.push((String::from(key), *value)); | ||
| } | ||
| json_response.clear(); | ||
|
|
||
| language_set.sort_by(|a, b| { | ||
| let (_, a_bytes) = a; | ||
| let (_, b_bytes) = b; | ||
|
|
||
| b_bytes.cmp(a_bytes) | ||
| }); | ||
|
|
||
| let mut languages: Vec<String> = vec![]; | ||
| for (language, _) in language_set { | ||
| languages.push(language); | ||
| } | ||
|
|
||
| Ok(languages) |
There was a problem hiding this comment.
ini juga, enak pake .map biar sok ganteng
…-use_chrono_serde
…list-languages # Conflicts: # backend/Cargo.toml
elianiva
approved these changes
Sep 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.