Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): config file wasnt copied #57

Merged
merged 1 commit into from
Oct 3, 2022
Merged

fix(backend): config file wasnt copied #57

merged 1 commit into from
Oct 3, 2022

Conversation

aldy505
Copy link
Member

@aldy505 aldy505 commented Oct 2, 2022

fixes custom repositories that are defined on target.yml, yet didn't show up on the /repo endpoint

@aldy505 aldy505 added the bug Something isn't working label Oct 2, 2022
@aldy505 aldy505 requested a review from elianiva October 2, 2022 09:25
@aldy505 aldy505 requested a review from ii64 as a code owner October 2, 2022 09:25
@aldy505 aldy505 self-assigned this Oct 2, 2022
ii64
ii64 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Collaborator

@ii64 ii64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config file default path is on /tmp/data.yml, do we need to change it somewhere else?

@aldy505
Copy link
Member Author

aldy505 commented Oct 2, 2022

The config file default path is on /tmp/data.yml, do we need to change it somewhere else?

no, it can always be configured to somewhere right?

@ii64
Copy link
Collaborator

ii64 commented Oct 2, 2022

no, it can always be configured to somewhere right?

Yes, CLI flags and environment variables

@elianiva elianiva merged commit ad0ff1e into master Oct 3, 2022
@elianiva elianiva deleted the feat/backend-use-config-file branch October 3, 2022 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ii64 ii64 ii64 approved these changes

@elianiva elianiva elianiva approved these changes

Assignees

@aldy505 aldy505

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldy505 @ii64 @elianiva