-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to set multiple tags with the buildpacks task #423
Comments
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
@vdemeester: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle rotten |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expected Behavior
With #415, the
buildpacks
task will be updated to use thecreator
binary. That allows users to add additional tags to the image by passing though-tag <TAG>
. I would expect you to be able to pass TAGS to the buildpacks task, and it would work.Actual Behavior
It doesn't work.
Additional Info
I spiked in working on this, but I found it non-trivial. Doing it in a good fashion (allowing users to say TAG:
latest this-tag use-this-image
) proves a bit difficult, because every one of those needs to be prefaced with-tag=
), and when I tried to use it as an input to thecreate
step, it gave me grief because it read it as an additional parameter to the task, instead of an argument.We may want to look into using https://github.com/tektoncd/pipeline/blob/master/docs/tasks.md#emitting-results to properly convert the input string into one we can use as an arg to the task, though that would necessitate converting it from a
Task
to aPipeline
. See tektoncd/pipeline#1950 and tektoncd/pipeline#1978 for more details.The text was updated successfully, but these errors were encountered: