Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing multiple workspaces into a task. #444

Closed
felixtran39 opened this issue Jul 24, 2020 · 10 comments
Closed

Passing multiple workspaces into a task. #444

felixtran39 opened this issue Jul 24, 2020 · 10 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@felixtran39
Copy link

felixtran39 commented Jul 24, 2020

Description

I have a pipeline that uses the git-clone task to clone a repository to a workspace. I do this for two different workspaces. Next, I attempt to pass both workspaces into a task. When running this pipeline, I see that it gets stuck on the task that I pass both workspaces into. (This task works fine when only one of the two workspaces is passed in).

Expected Behavior

Task finishes successfully.

Actual Behavior

Task is stuck in "PENDING".

When looking in the pod, I see this.

message: containers with incomplete status: [place-tools]
reason: ContainersNotInitialized
status: "False"
type: Initialized

Steps to Reproduce the Problem

  1. Create a pipeline 1. git-clone into a workspace, 2. git-clone into another workspace, 3. pass both workspaces into a task.
  2. Run the pipeline.
  3. Look at the pipelinerun and the taskruns resulting from the run. (Stuck in "PENDING")
@vdemeester
Copy link
Member

So, this is most likely due to the affinity assistant (see here). Overall, in the task you can define as many workspace as you want, but at runtime, you should, ideally, use only one PVC (with subpath in the workspace definition) so that you don't get into an unschedulable state.

/cc @jlpettersson

@yuwenma
Copy link

yuwenma commented Jul 24, 2020

@vdemeester Thanks Vincent! In our use case, we used the git-clone catalog to fetch the repos and our task has to use multiple repos. If it's not suggested to use more than one workspace in a task, is that possible to extend the functionality of the git-clone catalog, so as it can fetch multiple repos to some customized paths?

More context: In a CI/CD workflow, it's not unusual to use a separate repo to store (hydrated) app configurations. To use tekton as the CI/CD framework, the task would then have to deal with multiple repositories.
/cc @bobcatfish

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2020
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 21, 2020
@jlpettersson
Copy link
Member

More context: In a CI/CD workflow, it's not unusual to use a separate repo to store (hydrated) app configurations. To use tekton as the CI/CD framework, the task would then have to deal with multiple repositories.

@yuwenma I agree with this. I tried to reason about multiple repos in a CI/CD workflow in the end of this comment tektoncd/pipeline#3440 (comment), maybe you agree?

@vdemeester
Copy link
Member

/remove-lifecycle rotten

@tekton-robot tekton-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Nov 25, 2020
@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2021
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 25, 2021
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants