Update the git fetch task to include all params used in the Git PipelineResource #182
Conversation
tekton-robot
added
the
size/L
…ineResource This commit makes several changes to the fetch-git task in the catalog: 1. Update the set of params to match all those of the Git PipelineResource. This has been done because the Git PipelineResource is remaining alpha when the rest of Tekton Pipelines goes beta. This task should provide an easy transition for users currently relying on the pipeline resource. 2. Replace the volume mount with a workspace. This is done to promote workspaces as the way to weave volumes through a pipeline. 3. Emit the fetched SHA as a Task Result which will soon be consumable by other tasks in a pipeline. 4. Rename it to git-clone per feedback on the PR for the original fetch-git. This PR continues to use the git-init image that is built as part of Pipelines. I think that this is fine for now (?) but that we should eventually rewrite the git-init binary as a script directly inside the git-clone task so that users can more easily see exactly what the task does. On the bright side this does have the benefit that the behaviour of the task will exactly mirror the pipeline reosurce for compatibility's sake.
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
💯 agree. |
Changes
This commit makes several changes to the fetch-git task in the catalog:
Update the set of params to match all those of the Git PipelineResource. This
has been done because the Git PipelineResource is remaining alpha when the rest
of Tekton Pipelines goes beta. This task should provide an easy transition for
users currently relying on the pipeline resource.
Replace the volume mount with a workspace. This is done to promote workspaces
as the way to weave volumes through a pipeline.
Emit the fetched SHA as a Task Result which will soon be consumable by other
tasks in a pipeline.
Rename it to git-clone per feedback on the PR for the original fetch-git.
This PR continues to use the git-init image that is built as part of Tekton Pipelines.
I think that this is fine for now (?) but that we should eventually rewrite the
git-init binary as a script directly inside the git-clone task so that users can
more easily see exactly what the task does. On the bright side this does have the
benefit that the behaviour of the task will exactly mirror the pipeline reosurce
for compatibility's sake.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.