Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildpacks-v3 template for latest lifecycle #50

Merged
merged 3 commits into from
Jul 22, 2019

Conversation

ameyer-pivotal
Copy link
Contributor

@ameyer-pivotal ameyer-pivotal commented Jul 2, 2019

Signed-off-by: Andrew Meyer ameyer@pivotal.io

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@tekton-robot tekton-robot requested review from dlorenc and kimsterv July 2, 2019 16:43
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2019
@ameyer-pivotal
Copy link
Contributor Author

/assign @vdemeester

@vdemeester
Copy link
Member

/ok-to-test

@tekton-robot tekton-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2019
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ameyer-pivotal Thanks for the PR, but as is, it doesn't work, or more accurately the example can't work. A fix should allow this to work (with a different syntax) in the near future, but for now we should update the README with a working example.

buildpacks/README.md Outdated Show resolved Hide resolved
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how to handle the versionning, as this would only work a master/nightly pipeline deploy. I feel we should add some annotation (in the yaml) and some sort of ribbon (or warning), that this task currently only work on tektoncd/pipeline master, and will work with 0.6.0 and above.

buildpacks/README.md Outdated Show resolved Hide resolved
@ameyer-pivotal
Copy link
Contributor Author

ameyer-pivotal commented Jul 16, 2019

I wonder how to handle the versionning, as this would only work a master/nightly pipeline deploy. I feel we should add some annotation (in the yaml) and some sort of ribbon (or warning), that this task currently only work on tektoncd/pipeline master, and will work with 0.6.0 and above.

@vdemeester By annotation, do you simply mean a comment, or something more formal? For the warning, what mechanism were you thinking specifically to display it?

- Use correct syntax for volume claim
@dlorenc
Copy link
Contributor

dlorenc commented Jul 22, 2019

@vdemeester By annotation, do you simply mean a comment, or something more formal? For the warning, what mechanism were you thinking specifically to display it?

A comment in the documentation would be great for now. I'll open an issue to create a more formal method.

@dlorenc
Copy link
Contributor

dlorenc commented Jul 22, 2019

#53 to track the version issue.

@vdemeester
Copy link
Member

@vdemeester By annotation, do you simply mean a comment, or something more formal? For the warning, what mechanism were you thinking specifically to display it?

(Sorry I was off a few days) as @dlorenc said, right now a comment is fine. This is something we need to figure out for the long term 👼

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@ameyer-pivotal
Copy link
Contributor Author

@vdemeester @dlorenc Thanks for your response. I went ahead and added a compatibility note to the documentation. Please have a look and let me know if that works :)

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameyer-pivotal, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@tekton-robot tekton-robot merged commit 80b2fff into tektoncd:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants