-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update buildpacks-v3 template for latest lifecycle #50
Conversation
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
/assign @vdemeester |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ameyer-pivotal Thanks for the PR, but as is, it doesn't work, or more accurately the example can't work. A fix should allow this to work (with a different syntax) in the near future, but for now we should update the README with a working example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder how to handle the versionning, as this would only work a master/nightly pipeline deploy. I feel we should add some annotation (in the yaml) and some sort of ribbon (or warning), that this task currently only work on tektoncd/pipeline
master, and will work with 0.6.0 and above.
@vdemeester By annotation, do you simply mean a comment, or something more formal? For the warning, what mechanism were you thinking specifically to display it? |
- Use correct syntax for volume claim
A comment in the documentation would be great for now. I'll open an issue to create a more formal method. |
#53 to track the version issue. |
(Sorry I was off a few days) as @dlorenc said, right now a comment is fine. This is something we need to figure out for the long term 👼 |
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@vdemeester @dlorenc Thanks for your response. I went ahead and added a compatibility note to the documentation. Please have a look and let me know if that works :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameyer-pivotal, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrew Meyer ameyer@pivotal.io
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.