Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use golangci-lint config. #1106

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Actually use golangci-lint config. #1106

merged 2 commits into from
Apr 25, 2024

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Apr 17, 2024 •
edited
Loading

Changes

golangci-config uses .golangci.yaml as the default config path. Previously we were using .golang-ci.yaml so changes weren't taking affect.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@wlynch
Actually use golangci-lint config.
f8a3ec5 
golangci-config uses `.golangci.yaml` as the default config path.
Previously we were using `.golang-ci.yaml` so changes weren't taking
affect.
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2024
lcarva
lcarva reviewed Apr 17, 2024
View reviewed changes
.github/workflows/lint.yaml Outdated Show resolved Hide resolved
@wlynch wlynch requested a review from lcarva April 25, 2024 14:20
lcarva
lcarva approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@lcarva lcarva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 25, 2024
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcarva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@tekton-robot tekton-robot merged commit 2b5054e into tektoncd:main Apr 25, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcarva lcarva lcarva approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

Assignees

@lcarva lcarva

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wlynch @tekton-robot @lcarva