Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base image used in ko build (#1205) #1212

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update base image used in ko build (#1205) #1212

merged 1 commit into from
Sep 26, 2024

Conversation

lcarva
Copy link
Contributor

@lcarva lcarva commented Sep 23, 2024

Changes

The default base image, cgr.dev/chainguard/static, no longer provides all the platforms the Chains controller claims support for.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

Fix missing platforms in controller image

@lcarva
Update base image used in ko build (tektoncd#1205)
dca71dc 
The default base image, cgr.dev/chainguard/static, no longer provides
all the platforms the Chains controller claims support for.

Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@lcarva
Copy link
Contributor Author

lcarva commented Sep 23, 2024

/test pull-tekton-chains-unit-tests

wlynch
wlynch approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@wlynch wlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wlynch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2024
@tekton-robot tekton-robot merged commit 1390c44 into tektoncd:release-v0.22.x Sep 26, 2024
15 checks passed
@lcarva lcarva deleted the fix-platforms-release-v0.22 branch September 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlynch wlynch wlynch approved these changes

@chitrangpatel chitrangpatel Awaiting requested review from chitrangpatel

Assignees

@wlynch wlynch

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcarva @tekton-robot @wlynch