Skip to content

Commit

Permalink
Bump golangci-lint to v0.58.0
Browse files Browse the repository at this point in the history
This will bump golangci-lint to v0.58.0 and does
the changes in config file to fix the warnings

Also fix gofmt warnings
  • Loading branch information
piyush-garg authored and tekton-robot committed May 8, 2024
1 parent dc39e91 commit b0984e3
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 14 deletions.
8 changes: 0 additions & 8 deletions .errcheck.txt

This file was deleted.

14 changes: 11 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,23 @@ issues:
- path: _test\.go
linters:
- gosec
exclude-dirs:
- vendor
run:
issues-exit-code: 1
build-tags:
- e2e
skip-dirs:
- vendor
linters-settings:
errcheck:
exclude: .errcheck.txt
exclude-functions:
- (*github.com/tektoncd/pipeline/vendor/go.uber.org/zap.SugaredLogger).Sync
- flag.Set
- os.Setenv
- logger.Sync
- fmt.Fprintf
- fmt.Fprintln
- (io.Closer).Close
- updateConfigMap
staticcheck:
checks:
- '-SA1019' # ignore ClusterTask warning
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
GO = go
PKGS = $(or $(PKG),$(shell env GO111MODULE=on $(GO) list ./... | grep -v 'github\.com\/tektoncd\/cli\/third_party\/'))
PKGS = $(or $(PKG),$(shell env GO111MODULE=on $(GO) list ./... | grep -v 'github.com/tektoncd/cli/third_party/'))
BIN = $(CURDIR)/.bin

export GO111MODULE=on
Expand All @@ -11,7 +11,7 @@ M = $(shell printf "\033[34;1m🐱\033[0m")
TIMEOUT_UNIT = 5m
TIMEOUT_E2E = 20m

GOLANGCI_VERSION = v1.56.2
GOLANGCI_VERSION = v1.58.0

YAML_FILES := $(shell find . -type f -regex ".*y[a]ml" -print)

Expand Down
2 changes: 1 addition & 1 deletion tekton/release-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ spec:
- name: flags
value: "-v --timeout 20m"
- name: version
value: v1.56.2
value: v1.58.0
workspaces:
- name: source
workspace: shared-workspace
Expand Down

0 comments on commit b0984e3

Please sign in to comment.