Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Coverage on CI doesn't seem to be running anymore #576

Closed
chmouel opened this issue Jan 7, 2020 · 4 comments
Closed

Code Coverage on CI doesn't seem to be running anymore #576

chmouel opened this issue Jan 7, 2020 · 4 comments
Labels
area/test-infra Issues or PRs related to the testing infrastructure area/testing Issues or PRs related to testing

Comments

@chmouel
Copy link
Member

chmouel commented Jan 7, 2020

I don't think I have seen the PR code coverage anymore,

We need to figure out why is it disabled?

(and perhaps if that doesnt' work anymore see if we can fall back to https://codecovs.io)

/cc @vdemeester

@chmouel chmouel added area/test-infra Issues or PRs related to the testing infrastructure area/testing Issues or PRs related to testing labels Jan 7, 2020
@piyush-garg
Copy link
Contributor

It's working I think. Comment from last night #577 (comment)

@danielhelfand
Copy link
Member

I think it doesn't show if there is no difference in coverage? For instance, this pr is refactoring tests so it doesn't alter coverage.

@chmouel
Copy link
Member Author

chmouel commented Jan 8, 2020

Ah yes you guys are right!!
/close

@tekton-robot
Copy link
Contributor

@chmouel: Closing this issue.

In response to this:

Ah yes you guys are right!!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-infra Issues or PRs related to the testing infrastructure area/testing Issues or PRs related to testing
Projects
None yet
Development

No branches or pull requests

4 participants