Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Delete TaskRuns Associated with a PipelineRun #588

Closed
danielhelfand opened this issue Jan 10, 2020 · 3 comments
Closed
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@danielhelfand
Copy link
Member

danielhelfand commented Jan 10, 2020

The CLI as of v0.6.0 supports the ability to delete a Pipeline and its associated PipelineRuns as well as the ability to delete a Task and its TaskRuns. We should also add the ability to delete TaskRuns associated with a PipelineRun as part of deleting a PipelineRun.

This was originally thought of as part of #585, which refactored resource deletion for all resources.

@danielhelfand
Copy link
Member Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 10, 2020
@ghost ghost mentioned this issue Jan 14, 2020
5 tasks
@ghost
Copy link

ghost commented Jan 14, 2020

I believe this happens automatically when deleting a PipelineRun thanks to the tekton pipeline reconciler, at least from my initial testing:

λ kubectl get pipelineruns
NAME                  SUCCEEDED   REASON    STARTTIME   COMPLETIONTIME
demo-pipeline-run-1   Unknown     Running   7s          

λ kubectl get taskruns
NAME                                            SUCCEEDED   REASON      STARTTIME   COMPLETIONTIME
demo-pipeline-run-1-build-skaffold-app-588ps    Unknown     Pending     1s          
demo-pipeline-run-1-build-skaffold-web-z8fx8    Unknown     Pending     1s          
demo-pipeline-run-1-skaffold-unit-tests-997cv   True        Succeeded   9s          1s

λ tkn pr delete demo-pipeline-run-1
Are you sure you want to delete pipelinerun "demo-pipeline-run-1" (y/n): y
PipelineRun deleted: demo-pipeline-run-1

λ kubectl get pipelineruns
No resources found in default namespace.

λ kubectl get taskruns
No resources found in default namespace.

@danielhelfand
Copy link
Member Author

@sbwsg Gotcha! Thanks for researching this and clearing this up. Sorry for the confusion with the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants