Refactor delete command code to be a bit more DRY #585
Conversation
While implementing multiple delete I noticed that each delete command was implementing its own error handling and messaging even though each was doing exactly the same thing. This made working on the code cumbersome - I had to double check that I'd added each of my changes correactly across every repition of the delete command. So this commit introduces a helper type, Deleter, that does most of the repetitive work and is reused across all the delete commands.
tekton-robot
added
the
size/L
|
The following is the coverage report on pkg/.
|
Mostly because the function signature would be a bit gnarly when deleting both a resource and its relations I think. |
|
/test pull-tekton-cli-unit-tests |
tekton-robot
added
the
approved
| } | ||
|
|
||
| return multierr.Combine(errs...) | ||
| d := deleter.New("PipelineRun", func(pipelineRunName string) error { |
There was a problem hiding this comment.
Not that this should happen in this pr, but it may be a good idea to have TaskRuns be a related resource for PipelineRuns.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
While implementing multiple delete I noticed that each delete command was implementing its own error handling and messaging even though each was doing exactly the same thing. This made working on the code more error-prone - I had to double check that I'd added each of my changes correctly across every repetition of the delete behaviour.
So this commit introduces a helper type,
Deleter, that does most of the repetitive work and is now reused across all the delete commands.Submitter Checklist
make check