Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Approach to Referring to Tekton Resources Through CLI #605

Closed
danielhelfand opened this issue Jan 15, 2020 · 5 comments
Closed
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@danielhelfand
Copy link
Member

We should have a consistent approach to how resources are referenced in tkn. Currently, there are several different approaches used. An example is TaskRun:

TaskRun:

emptyMsg = "No TaskRuns found"

taskrun:

fmt.Fprintf(os.Stderr, "Failed to list taskruns from %s namespace \n", p.Namespace())

Taskrun:

fmt.Fprintf(opt.stream.Out, "Taskrun started: %s\n", trCreated.Name)

My thought would be to capitalize the resource name (TaskRun) or to lowercase the resource name completely (taskrun).

While I am using TaskRun as an example, this applies to all resources in the CLI. I have no preference on how to refer to resources, but we should be consistent throughout the CLI.

@danielhelfand
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 15, 2020
@chmouel
Copy link
Member

chmouel commented Jan 15, 2020

Camel case names i.e: TaskRuns feels more natural to me!

@danielhelfand
Copy link
Member Author

/assign

@danielhelfand
Copy link
Member Author

All prs needed to close this issue should be open. Once they are merged, this can be closed.

@danielhelfand
Copy link
Member Author

Closing this since all related prs are in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

5 participants