-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent Approach to Referring to Tekton Resources Through CLI #605
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
Comments
/kind cleanup |
tekton-robot
added
the
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
label
Jan 15, 2020
Camel case names i.e: |
4 tasks
/assign |
This was referenced Jun 23, 2020
4 tasks
This was referenced Oct 20, 2020
This was referenced Oct 20, 2020
All prs needed to close this issue should be open. Once they are merged, this can be closed. |
Closing this since all related prs are in. |
This was referenced Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
We should have a consistent approach to how resources are referenced in
tkn
. Currently, there are several different approaches used. An example isTaskRun
:TaskRun:
cli/pkg/cmd/taskrun/list.go
Line 36 in 84e7da6
taskrun:
cli/pkg/cmd/taskrun/list.go
Line 82 in 84e7da6
Taskrun:
cli/pkg/cmd/task/start.go
Line 239 in 4ae08d7
My thought would be to capitalize the resource name (
TaskRun
) or to lowercase the resource name completely (taskrun
).While I am using
TaskRun
as an example, this applies to all resources in the CLI. I have no preference on how to refer to resources, but we should be consistent throughout the CLI.The text was updated successfully, but these errors were encountered: