-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common Way of Referring to Tekton Resources for User Facing Messages: ClusterTask #1035
Conversation
The following is the coverage report on the affected files.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
/cc @pradeepitm12 @piyush-garg
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/test pull-tekton-cli-integration-tests-0_10 |
Part of #605
This pull request changes all user-facing messages to use
ClusterTask
andTaskRun
instead of a variety of ways it is referenced throughouttkn
(e.g.,taskrun
,TaskRun
, etc.).This pull request only focuses on
tkn clustertask
commands, but there are other ClusterTask/TaskRun references throughouttkn
that should be updated as well, but will be addressed in pull requests pertaining to the commands or helper packages where TaskRun is referenced.Additionally, this pr removes printing error messages to Stderr, and instead returns the errors to be handled by Cobra instead.
Submitter Checklist
make check
make generated
Release Notes