Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Way of Referring to Tekton Resources for User Facing Messages: ClusterTask #1035

Merged
merged 1 commit into from
Jun 29, 2020
Merged

Conversation

danielhelfand
Copy link
Member

Part of #605

This pull request changes all user-facing messages to use ClusterTask and TaskRun instead of a variety of ways it is referenced throughout tkn (e.g., taskrun, TaskRun, etc.).

This pull request only focuses on tkn clustertask commands, but there are other ClusterTask/TaskRun references throughout tkn that should be updated as well, but will be addressed in pull requests pertaining to the commands or helper packages where TaskRun is referenced.

Additionally, this pr removes printing error messages to Stderr, and instead returns the errors to be handled by Cobra instead.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

Release Notes

Standardize the use of ClusterTask/TaskRun in user-facing messages for tkn clustertask commands

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 26, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/describe.go 65.2% 66.1% 1.0
pkg/cmd/clustertask/list.go 75.0% 80.8% 5.8

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow
/cc @pradeepitm12 @piyush-garg

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 29, 2020
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 29, 2020
@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-integration-tests-0_10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants