Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tektoncd/pipeline to v0.12.1 #1001

Merged
merged 1 commit into from
May 28, 2020

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented May 27, 2020

This will bump tektoncd/pipeline to v0.12.1
as dependency in vendor

Fixes #983
Fixes #984

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Bump tektoncd/pipeline to v0.12.1

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 27, 2020
Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependency bumps look fine to me, but making a note that I don't see that #949 is resolved with this dependency bump. Still seeing no statuses reported.

@danielhelfand danielhelfand added this to the 0.10.0 🐅 milestone May 27, 2020
@piyush-garg
Copy link
Contributor Author

@danielhelfand Thanks for pointing out this. I checked on the pipeline, the fix added will be in 0.13.x I will update commit message and description

This will bump tektoncd/pipeline to v0.12.1
as dependency in vendor

Fixes tektoncd#983
Fixes tektoncd#984
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
Copy link
Contributor

@pradeepitm12 pradeepitm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@tekton-robot tekton-robot merged commit 85e53f7 into tektoncd:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump pipeline and triggers dep Update knative/pkg
5 participants