Add support for embedded trigger binding to EventListener describe command

[savitaashture]

Changes

Added changes to support embedded trigger binding to EventListener describe command

Fixes #1004

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Output:

tkn el describe github-listener-interceptor -n clitest
Name:                      github-listener-interceptor
Namespace:                 clitest
Service Account:           tekton-triggers-github-sa
Service Type:              NodePort
URL:                       http://el-github-listener-interceptor.clitest.svc.cluster.local:8080
EventListnerServiceName:   el-github-listener-interceptor
 
EventListenerTriggers

 NAME
 ∙ github-listener
 
 BINDINGS

  REF                 KIND             APIVERSION
  ∙ github-binding    TriggerBinding   
  ∙ github-binding1   TriggerBinding   
  ∙ github-binding2   TriggerBinding   v1alpha1
 
  SPEC
  ∙ Params
    gitrevision        $(body.head_commit.id)
    gitrepositoryurl   $(body.repository.url)
    gitrevision        $(body.head_commit.id)
    gitrepositoryurl   $(body.repository.url)
    gitrevision        $(body.head_commit.id)
    gitrepositoryurl   $(body.repository.url)
  ∙ Params
    gitrevision        $(body.head_commit.id)
    gitrepositoryurl   $(body.repository.url)
 
 TEMPLATE NAME       APIVERSION
 ∙ github-template   
 
 INTERCEPTORS
- github:
    eventTypes:
    - pull_request
    secretRef:
      secretKey: secretToken
      secretName: github-secret

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/eventlistener/describe.go	82.0%	83.7%	1.7

[danielhelfand]

Looks fine to me for the most part, but am curious why APIVERSION isn't being populated when I run this locally? I also noticed it's missing from your pr description out so thought I would ask.

[piyush-garg]

I would prefer all binding ref to be together in single table

[piyush-garg]

Something like

Name:        el1
Namespace:   ns
 
EventListenerTriggers

 BINDINGS

  REF   KIND                    APIVERSION
  tb1   TriggerBinding          
  tb2   ClusterTriggerBinding   v1alpha1
  tb3   TriggerBinding          v1alpha1

  SPEC
  Params
    key    value
    key1   value1
    key2   value2
 
 TEMPLATE NAME   APIVERSION
 tt1             v1alpha1

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/eventlistener/describe.go	82.0%	86.4%	4.4

[savitaashture]

Looks fine to me for the most part, but am curious why APIVERSION isn't being populated when I run this locally? I also noticed it's missing from your pr description out so thought I would ask.

Its because while creating EventListener yaml i have not mentioned specific APIVersion so thats why its not showing in the Description.
But if we specify in the yaml then it will display
I have updated PR description please have a look
Thank you

[tekton-robot]

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/cmd/eventlistener/describe.go	82.0%	86.4%	4.4

[danielhelfand]

/lgtm

[chmouel]

/lgtm
/approve

👍

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chmouel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment