Reorganise cli E2E folder structure #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XXL
praveen4g0
changed the title
tekton-robot
added
the
do-not-merge/work-in-progress
|
/test pull-tekton-cli-integration-tests-0_10 |
praveen4g0
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
praveen4g0
changed the title
|
/assign @piyush-garg @pradeepitm12 |
|
@danielhelfand I have organised E2E package structure, please do let me know if you feel we can organise it in better way. |
pradeepitm12
reviewed
Jul 9, 2020
vdemeester
reviewed
Jul 9, 2020
There was a problem hiding this comment.
One nit that can be tackle later. I agree with @pradeepitm12 I am not sure about the framework package, but it's under the test and I don't have a better name so seems fine.
/lgtm
/cc @danielhelfand
tekton-robot
added
size/XL
|
/lgtm |
|
/test pull-tekton-cli-build-tests |
|
/retest |
1 similar comment
|
/retest |
tekton-robot
added
the
needs-rebase
|
@praveen4g0: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@pradeepitm12 @vdemeester can we merge this ? |
praveen4g0
force-pushed
the
cli-e2e
branch
2 times, most recently
from
b0304d8
to
018d62b
Compare
vdemeester
reviewed
Jul 21, 2020
piyush-garg
removed
the
needs-rebase
tekton-robot
added
the
needs-rebase
|
@praveen4g0: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fix lint errors
|
/lgtm |
vdemeester
approved these changes
Jul 24, 2020
tekton-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
piyush-garg
removed
the
needs-rebase
danielhelfand
added a commit
that referenced
this pull request
Aug 27, 2020
#1084 | [Pradeep Kumar] update version in readme | 2020/07/24-16:56 #1044 | [pthangad] Organize e2e | 2020/07/24-21:25 #1076 | [chetan-rns] Display results in task/taskrun describe command | 2020/07/29-05:54 #1051 | [vinamra28] ClusterTask start interactive mode | 2020/07/30-15:51 #1101 | [Daniel Helfand] add new line for No ClusterTasks found output | 2020/08/04-11:02 #1105 | [vinamra28] Display Results in the output of ClusterTask describe command | 2020/08/05-21:43 #1088 | [Daniel Helfand] add ability to specify podtemplate for taskrun/pipelinerun | 2020/08/10-16:24 #1108 | [Daniel Helfand] add triggers installation for e2e tests | 2020/08/12-16:54 #1110 | [Divyansh42] Display results in the output of pipeline/pipelinerun describe command | 2020/08/12-22:29 #1110 | [Divyansh42] Modify e2e test for pipeline | 2020/08/12-22:29 null | [vinamra28] Add --use-param-defaults option for tkn clustertask start | 2020/08/17-14:46 null | [rudeigerc] Fix the display of 0 Value for Timeout with tkn tr/pr describe | 2020/08/17-15:08 null | [Daniel Helfand] add check for timeout status for pipelinerun and taskrun cancel | 2020/08/18-13:43 null | [Vincent Demeester] pkg/suggestions: print help and error out 🏢 | 2020/08/18-15:57 null | [Vincent Demeester] pkg/suggestions: no help on subcommand errors | 2020/08/18-17:27 null | [Pratik Jagrut] Add EventListener's AVAILABLE Status with tkn eventlistener list | 2020/08/18-19:31 null | [Piyush Garg] Bump pipeline dep to v0.15.2 | 2020/08/19-04:43 null | [Piyush Garg] Bump triggers dep to v0.7.0 | 2020/08/19-06:01 null | [Daniel Helfand] consistent error messaging for triggers commands | 2020/08/19-07:13 null | [rudeigerc] Throw error when deleting tr/pr with non-existing task/pipeline | 2020/08/19-07:32 null | [Daniel Helfand] copy over pipelinerun and taskrun spec for --last and use run options | 2020/08/24-06:46 null | [vinamra28] Display Workspaces in the output of ClusterTask describe command | 2020/08/25-15:02 null | [vinamra28] Display Workspaces in the output of Task describe command | 2020/08/25-15:02 null | [vinamra28] Display workspaces in the output of TaskRun describe command | 2020/08/25-15:02 null | [Piyush Garg] Refactor status formatting | 2020/08/25-17:04 null | [Divyansh42] Modify --use-param-defaults flag and add e2e test | 2020/08/26-05:23 null | [Piyush Garg] Refactor taskrun description | 2020/08/26-09:40 null | [vinamra28] Display Workspaces in the output of Pipeline describe command | 2020/08/26-11:15 null | [vinamra28] Display Workspaces in the output of PipelineRun describe command | 2020/08/26-11:15 Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
No changes to code
Restructured/Reorganise folders for better readability.
Remove unused code
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes