Add Workspaces in Release pipeline instead of PipelineResources #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
/test pull-tekton-cli-integration-tests |
tekton-robot
added
do-not-merge/release-note-label-needed
|
/release-note-none |
tekton-robot
added
release-note-none
vinamra28
changed the title
Currently release pipeline is using PipelineResources so instead of that we are replacing them with workspaces and also adding the git-clone task. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
force-pushed
the
vinamra28/release-pipeline-cleanup
branch
from
ef87c31
to
ff6d9ad
Compare
|
@vdemeester could you please review 😅 |
|
/lgtm |
vdemeester
reviewed
Jul 21, 2020
There was a problem hiding this comment.
Overall looks good to me. I think we should go ahead and get this in — and exercices it during next release 😝
/cc @danielhelfand @chmouel @piyush-garg
Signed-off-by: vinamra28 <vinjain@redhat.com>
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pradeepitm12 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/test pull-tekton-cli-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently release pipeline is using PipelineResources so instead of that we are replacing them with workspaces and also adding the git-clone task.
Closes #1019
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.