adds finally logs in pipelinerun #1077

pradeepitm12 · 2020-07-20T12:37:52Z

closes #1054

this adds finally logs in pipelinerun logs command in follow and
non follow mode

Signed-off-by: Pradeep Kumar pradkuma@redhat.com

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

Includes tests (if functionality changed/added)
Run the code checkers with make check
Regenerate the manpages, docs and go formatting with make generated
Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

linux-foundation-easycla · 2020-07-20T12:37:55Z

The committers are authorized under a signed CLA.

✅ PRADEEP KUMAR (8b6652f2d65204eaef1ecddb5d63263c184cf799)

tekton-robot · 2020-07-20T12:40:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

tekton-robot · 2020-07-20T12:46:09Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

vdemeester · 2020-07-21T09:57:35Z

/retest

vdemeester

SGTM

vdemeester · 2020-07-21T09:59:00Z

pkg/cmd/pipelinerun/logs_test.go

+	test.AssertOutput(t, expected, output)
+}
+
+/*func TestPipelinerunLog_with_follow_mode_finally_task_v1beta1(t *testing.T) {


We should removed this code if commented 😉

And write an e2e tests instead for it 😝

Yeh 😝
Changed this to e2e

tekton-robot · 2020-07-21T12:29:59Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

tekton-robot · 2020-07-21T12:39:36Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

pradeepitm12 · 2020-07-21T13:08:14Z

/retest

pradeepitm12 · 2020-07-21T13:25:03Z

need to ignore finally related test for v0.10.0

danielhelfand · 2020-07-21T15:03:13Z

need to ignore finally related test for v0.10.0

This is what I did in #1066:

cli/test/e2e/cli.go

Line 218 in 209581e

func (e TknRunner) CheckVersion(component string, version string) bool {

And used in test:

cli/test/e2e/task/start_test.go

Line 130 in 209581e

if tkn.CheckVersion("Pipeline", "v0.10.2") {

tekton-robot · 2020-07-21T15:40:04Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

pradeepitm12 · 2020-07-21T15:40:43Z

need to ignore finally related test for v0.10.0

This is what I did in #1066:

cli/test/e2e/cli.go

Line 218 in 209581e

func (e TknRunner) CheckVersion(component string, version string) bool {

And used in test:

cli/test/e2e/task/start_test.go

Line 130 in 209581e

if tkn.CheckVersion("Pipeline", "v0.10.2") {

Thank you:smiley: this is helpful

tekton-robot · 2020-07-21T16:08:24Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

danielhelfand · 2020-07-21T17:31:56Z

test/e2e/pipelinerun/pipelinerun_test.go

+	t.Logf("Creating pipelinerun in namespace: %s", namespace)
+	e2e.Assert(t, kubectl.Create(e2e.ResourcePath("pipelinerun-with-finally.yaml")), icmd.Success)
+
+	t.Run("Pipelinerun logs with finally  "+namespace, func(t *testing.T) {


Remove nested t.Run:

t.Run("Pipelinerun logs with finally "+namespace, func(t *testing.T) { res := tkn.Run("pipelinerun", "logs", "exit-handler", "-f") log := res.Stdout() s := []string{ "[print-msg : main] printing a message\n", "[echo-on-exit : main] finally\n", } expected := strings.Join(s, "\n") + "\n" e2e.AssertOutput(t, expected, log) })

tekton-robot · 2020-07-21T17:58:56Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

pradeepitm12 · 2020-07-22T05:48:00Z

/test pull-tekton-cli-unit-tests

tekton-robot · 2020-07-22T06:01:01Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

closes tektoncd#1054 this adds finally logs in pipelinerun logs command in follow and non follow mode Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

tekton-robot · 2020-07-22T06:50:14Z

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/pipelinerun/tracker.go	94.3%	84.4%	-9.8

pradeepitm12 · 2020-07-22T06:59:14Z

/test pull-tekton-cli-integration-tests

piyush-garg · 2020-07-22T07:15:55Z

/lgtm

vdemeester

/meow

tekton-robot · 2020-07-22T09:22:35Z

@vdemeester:

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

tekton-robot · 2020-07-22T09:22:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jul 20, 2020

tekton-robot requested review from sthaha and vdemeester July 20, 2020 12:37

tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 20, 2020

pradeepitm12 force-pushed the finally-logs-1054 branch from 9aed2ff to 8b6652f Compare July 20, 2020 12:42

vdemeester reviewed Jul 21, 2020

View reviewed changes

pradeepitm12 force-pushed the finally-logs-1054 branch from 8b6652f to aebc9b4 Compare July 21, 2020 12:26

pradeepitm12 changed the title ~~WIP: adds finally logs in pipelinerun~~ adds finally logs in pipelinerun Jul 21, 2020

tekton-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 21, 2020

pradeepitm12 force-pushed the finally-logs-1054 branch from aebc9b4 to ab5e22d Compare July 21, 2020 12:36

pradeepitm12 force-pushed the finally-logs-1054 branch from ab5e22d to d296cd2 Compare July 21, 2020 15:36

pradeepitm12 force-pushed the finally-logs-1054 branch from d296cd2 to 8449c2b Compare July 21, 2020 16:04

danielhelfand reviewed Jul 21, 2020

View reviewed changes

pradeepitm12 force-pushed the finally-logs-1054 branch from 8449c2b to 16aeef6 Compare July 21, 2020 17:55

pradeepitm12 force-pushed the finally-logs-1054 branch from 16aeef6 to ca664cc Compare July 22, 2020 05:57

adds finally logs in pipelinerun

75162c7

closes tektoncd#1054 this adds finally logs in pipelinerun logs command in follow and non follow mode Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>

pradeepitm12 force-pushed the finally-logs-1054 branch from ca664cc to 75162c7 Compare July 22, 2020 06:47

tekton-robot assigned piyush-garg Jul 22, 2020

tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2020

vdemeester approved these changes Jul 22, 2020

View reviewed changes

tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2020

tekton-robot merged commit bd1f342 into tektoncd:master Jul 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds finally logs in pipelinerun #1077

adds finally logs in pipelinerun #1077

pradeepitm12 commented Jul 20, 2020 •

edited

Loading

linux-foundation-easycla bot commented Jul 20, 2020 •

edited

Loading

tekton-robot commented Jul 20, 2020

tekton-robot commented Jul 20, 2020

vdemeester commented Jul 21, 2020

vdemeester left a comment

vdemeester Jul 21, 2020

vdemeester Jul 21, 2020

pradeepitm12 Jul 21, 2020

tekton-robot commented Jul 21, 2020

tekton-robot commented Jul 21, 2020

pradeepitm12 commented Jul 21, 2020

pradeepitm12 commented Jul 21, 2020

danielhelfand commented Jul 21, 2020

tekton-robot commented Jul 21, 2020

pradeepitm12 commented Jul 21, 2020

tekton-robot commented Jul 21, 2020

danielhelfand Jul 21, 2020

tekton-robot commented Jul 21, 2020

pradeepitm12 commented Jul 22, 2020

tekton-robot commented Jul 22, 2020

tekton-robot commented Jul 22, 2020

pradeepitm12 commented Jul 22, 2020

piyush-garg commented Jul 22, 2020

vdemeester left a comment

tekton-robot commented Jul 22, 2020

tekton-robot commented Jul 22, 2020

adds finally logs in pipelinerun #1077

adds finally logs in pipelinerun #1077

Conversation

pradeepitm12 commented Jul 20, 2020 • edited Loading

Changes

Submitter Checklist

Release Notes

linux-foundation-easycla bot commented Jul 20, 2020 • edited Loading

tekton-robot commented Jul 20, 2020

tekton-robot commented Jul 20, 2020

vdemeester commented Jul 21, 2020

vdemeester left a comment

Choose a reason for hiding this comment

vdemeester Jul 21, 2020

Choose a reason for hiding this comment

vdemeester Jul 21, 2020

Choose a reason for hiding this comment

pradeepitm12 Jul 21, 2020

Choose a reason for hiding this comment

tekton-robot commented Jul 21, 2020

tekton-robot commented Jul 21, 2020

pradeepitm12 commented Jul 21, 2020

pradeepitm12 commented Jul 21, 2020

danielhelfand commented Jul 21, 2020

tekton-robot commented Jul 21, 2020

pradeepitm12 commented Jul 21, 2020

tekton-robot commented Jul 21, 2020

danielhelfand Jul 21, 2020

Choose a reason for hiding this comment

tekton-robot commented Jul 21, 2020

pradeepitm12 commented Jul 22, 2020

tekton-robot commented Jul 22, 2020

tekton-robot commented Jul 22, 2020

pradeepitm12 commented Jul 22, 2020

piyush-garg commented Jul 22, 2020

vdemeester left a comment

Choose a reason for hiding this comment

tekton-robot commented Jul 22, 2020

tekton-robot commented Jul 22, 2020

pradeepitm12 commented Jul 20, 2020 •

edited

Loading

linux-foundation-easycla bot commented Jul 20, 2020 •

edited

Loading