Display Workspaces in the output of pipeline/pipelinerun describe command #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workspaces declared in the Pipeline will be displayed in the output of pipeline describe command. When we will do `tkn pipeline desc <name>` workspace name and description will be displayed in the output. Signed-off-by: vinamra28 <vinjain@redhat.com>
tekton-robot
added
release-note
tekton-robot
added
the
size/L
|
/test pull-tekton-cli-integration-tests-0_10 |
vinamra28
changed the title
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/test pull-tekton-cli-integration-tests-0_10 |
1 similar comment
|
/test pull-tekton-cli-integration-tests-0_10 |
piyush-garg
reviewed
Aug 26, 2020
vinamra28
force-pushed
the
vinamra28/pipeline-pipelinerun-describe-workspaces
branch
from
ee377b1
to
d3be21a
Compare
|
/test pull-tekton-cli-integration-tests-0_10 |
vdemeester
approved these changes
Aug 26, 2020
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
requested review from
danielhelfand,
piyush-garg and
pradeepitm12
tekton-robot
added
the
approved
piyush-garg
reviewed
Aug 26, 2020
The workspaces declared in the PipelineRun will be displayed in the output of pipelinerun describe command. When we will do `tkn pipelinerun desc <name>` workspace name, subpath and workspace binding will be displayed in the output. Signed-off-by: vinamra28 <vinjain@redhat.com>
vinamra28
force-pushed
the
vinamra28/pipeline-pipelinerun-describe-workspaces
branch
from
d3be21a
to
9b7e53d
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test pull-tekton-cli-integration-tests-0_10 |
vinamra28
deleted the
vinamra28/pipeline-pipelinerun-describe-workspaces
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The workspaces declared in the pipeline/pipelinerun will be displayed in the output of their respective describe command.
tkn pipeline desc <pipeline-name>workspace name and description will be displayed in the outputtkn pipelinerun desc <pipelinerun-name>workspace name, subdir and workspace binding will be displayed as part of outputCloses #1048
Signed-off-by: vinamra28 vinjain@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes