tests: import pipeline internal builders 🏒 #1177
Conversation
|
@vdemeester: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
requested review from
danielhelfand,
piyush-garg and
pradeepitm12
tekton-robot
added
kind/misc
|
/release-note-none |
tekton-robot
added
release-note-none
|
The following is the coverage report on the affected files.
|
vdemeester
force-pushed
the
import-internal-builder
branch
2 times, most recently
from
c5efa65
to
7ea3a39
Compare
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
vdemeester
force-pushed
the
import-internal-builder
branch
from
7ea3a39
to
413482d
Compare
|
The following is the coverage report on the affected files.
|
vdemeester
force-pushed
the
import-internal-builder
branch
from
413482d
to
f670621
Compare
|
The following is the coverage report on the affected files.
|
|
/test pull-tekton-cli-integration-tests |
|
/lgtm One question, are these builders from 0.16? |
0.15.2 (because they were removed before 0.16.0) |
But the internal is there in 0.16 right? They are removed from test/builder pkg |
yeah it's there lol, that's a good point. I can bump it to 0.16.0 if needed in a follow-up 😝 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
I don't think people are using anything from CLI to use builders. |
|
ah, that needs a rebase 😅 |
|
Yeah, from #1168. |
Importing pipeline internal builders in cli so that we can safely take time to migrate out of them with less pressure (and with less dependency problems). Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
import-internal-builder
branch
from
f670621
to
1d3235a
Compare
|
Rebased 😉 👼 🙃 |
|
The following is the coverage report on the affected files.
|
|
/lgtm |
|
/retest |
#1167 | [Daniel Helfand] update condition tests from test builders to structs | 2020/09/16-11:10 #1154 | [vinamra28] Enable auto-select support in ClusterTaskDescribe if only one is present | 2020/09/16-17:00 #1154 | [vinamra28] Enable auto-select support in TaskRunDescribe if only one is present | 2020/09/16-17:00 #1173 | [Daniel Helfand] update README versions for v0.12.1 | 2020/09/16-17:21 #1176 | [Bart] Artwork/Logo added to the top of the README. | 2020/09/16-18:14 #1172 | [Chmouel Boudjnah] Fix rpm build for release | 2020/09/17-14:34 #1168 | [Daniel Helfand] update clustertask tests from test builders to structs | 2020/09/18-13:26 #1177 | [Vincent Demeester] tests: import pipeline internal builders 🏒 | 2020/09/18-17:31 #1179 | [vinamra28] Use --prefix-name option for tkn clustertask start | 2020/09/18-23:07 #1182 | [Daniel Helfand] update pipelineresource tests from test builders to structs | 2020/09/21-14:29 null | [Vincent Demeester] Remove release-note block indentation in PR template 🌮 | 2020/09/22-11:57 null | [savitaashture] Modify tkn version to accept ldflag and namespace flag | 2020/09/24-10:14 null | [savitaashture] Fix deployment fetch issue for multiple namespaces | 2020/09/25-11:54 null | [PuneetPunamiya] This patch fixes: | 2020/09/28-19:27 null | [Divyansh42] Modify tkn version output to hide Triggers and Dashboard version if they are not installed and added required unit tests. | 2020/09/29-04:57 null | [Piyush Garg] Bump pipeline and triggers dep | 2020/09/29-13:55 null | [Divyansh42] Enable auto-select support in pipelineDescribe if only one pipeline is present | 2020/09/29-17:29 null | [vinamra28] Add --use-taskrun for ClusterTask start | 2020/09/30-11:08 null | [Divyansh42] Enable auto select support in PipelineRunDescribe if only one PipelineRun is present | 2020/09/30-13:13 Signed-off-by: Daniel Helfand <helfand.4@gmail.com>
Changes
Importing pipeline internal builders in cli so that we can safely take
time to migrate out of them with less pressure (and with less
dependency problems).
This doesn't prevent to fix #1145, it's just putting less pressure on getting it done before the next release 😉
Signed-off-by: Vincent Demeester vdemeest@redhat.com
/cc @piyush-garg @danielhelfand @pradeepitm12
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
/kind misc