Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable auto select support in PipelineRunDescribe if only one PipelineRun Present #1190

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Enable auto select support in PipelineRunDescribe if only one PipelineRun Present #1190

merged 1 commit into from
Sep 30, 2020

Conversation

divyansh42
Copy link
Member

@divyansh42 divyansh42 commented Sep 29, 2020

Changes

When only one pipelineRun is present then instead of prompting to user to select the
pipelineRun at the time of running the pipelineRun describe command then pipelineRun will
be autoselected and the output will be displayed.

Signed-off-by: Divyansh42 diagrawa@redhat.com

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Enable auto-select support in PipelineRun describe command if only one is present

…eRun is present

When only one pipelineRun is present then instead of prompting to user to select the
pipelineRun at the time of running the pipelineRun describe command then pipelineRun will
be autoselected and the output will be displayed.

Signed-off-by: Divyansh42 <diagrawa@redhat.com>
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 29, 2020
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 29, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on the affected files.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/pipelinerun/describe.go 56.9% 64.7% 7.8

@divyansh42
Copy link
Member Author

/test pull-tekton-cli-integration-tests-0_10

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 30, 2020
@divyansh42
Copy link
Member Author

/retest

2 similar comments
@divyansh42
Copy link
Member Author

/retest

@vinamra28
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants