Change --nocolour to --no-color #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
The following is the coverage report on the affected files.
|
vdemeester
approved these changes
Oct 27, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Seems to be issue with CI. No failures being reported. /retest |
|
/retest |
|
/lgtm |
pradeepitm12
added a commit
that referenced
this pull request
Nov 16, 2020
#1215 | [Piyush Garg] Update readme for 0.13.1 and fix lint task | 2020/10/21-14:41 #1210 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: ClusterTriggerBinding | 2020/10/21-15:55 #1209 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: Condition | 2020/10/21-17:41 #1213 | [Daniel Helfand] common way of referring to tekton resources in user facing messages: TriggerTemplate | 2020/10/21-19:33 #1214 | [shuheiktgw] Fix unit test failures with go 1.15 | 2020/10/22-04:19 #1203 | [Sunil Thaha] Integrate Hub commands into tkn | 2020/10/22-04:41 #1217 | [Daniel Helfand] fix alignment of usage | 2020/10/22-18:47 #1218 | [Daniel Helfand] document NO_COLOR and edit README headers | 2020/10/26-15:40 #1224 | [Daniel Helfand] change --nocolour to --no-color | 2020/10/28-02:57 #1221 | [SM43] Updates Hub Dependency | 2020/10/28-04:51 null | [Daniel Helfand] deprecate -c shorthand for tkn version --check | 2020/11/03-15:37 null | [Pradeep Kumar] Bump pipeline and triggers deps | 2020/11/04-20:12 null | [Daniel Helfand] do not delete clustertask taskruns with --task flag | 2020/11/04-20:59 null | [Piyush Garg] Fix APIversion not shown on describe commands | 2020/11/05-10:54 null | [Pratik Jagrut] Add --all-namespaces flag to tkn triggerbinding list command | 2020/11/06-12:25 null | [Pratik Jagrut] Add --all-namespaces flag to tkn eventlistener list command | 2020/11/06-16:04 null | [vinamra28] Add --all-namespaces flag to TriggerTemplate List subcommand | 2020/11/06-19:39 null | [Chmouel Boudjnah] Make sure we target LTS for ubuntus | 2020/11/06-21:12 null | [Pratik Jagrut] Add --all-namespaces flag to tkn condition list command | 2020/11/09-14:14 null | [Daniel Helfand] remove EventListener log output assertion from e2e tests | 2020/11/11-16:52 null | [Pradeep Kumar] bump pipleine dependency to v0.18.0 | 2020/11/12-11:28 null | [dullest] fix function name typo | 2020/11/12-15:17 null | [Vincent Demeester] Makefile: remove darwin/386 from cross target 🌮 | 2020/11/13-15:58 null | [Pratik Jagrut] Add --no-headers flag to tkn clustertask list command | 2020/11/16-09:50 null | [Pratik Jagrut] Add --no-headers flag to tkn clustertriggerbinding list command | 2020/11/16-10:24 Signed-off-by: Pradeep Kumar <pradkuma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1219
This pull request changes to
--nocolouroption to--no-colorwhile still supporting the--nocolourflag. In documentation and help commands,--no-colorwill be shown as the available option. However,--nocolourshould still work as was implemented previously.If there is a recommended approach to supporting old flag names better than the one I have implemented here (which basically adds
--no-coloras a new flag and hides but still supports--nocolour), please let me know.Submitter Checklist
make checkmake generatedRelease Notes