Allow --prefix-name and --timeout to be Overrode when using --last or --use-run Options #1242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
|
/retest |
|
/test pull-tekton-cli-integration-tests-0_10 |
piyush-garg
approved these changes
Dec 1, 2020
tekton-robot
added
the
approved
chmouel
approved these changes
Dec 1, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel, piyush-garg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm Looking Good! 🤙🏽 |
chmouel
added a commit
that referenced
this pull request
Dec 17, 2020
#1260 | [vinamra28] Use goreleaser task from tektoncd/catalog | 2020/11/18-09:01 #1261 | [Pradeep Kumar] update README to v0.14.0 | 2020/11/18-12:25 #1259 | [Pratik Jagrut] Add --no-headers flag to tkn condition list command | 2020/11/25-12:19 #1257 | [Chmouel Boudjnah] Use debian/VERSION when building debian package | 2020/11/25-12:33 #1254 | [Pratik Jagrut] Add --no-headers flag to tkn triggerbinding list command | 2020/11/25-14:13 #1255 | [Pratik Jagrut] Add --no-headers flag to tkn triggertemplate list command | 2020/11/25-14:13 #1258 | [Pratik Jagrut] Add --no-headers flag to tkn eventlistener list command | 2020/11/25-15:11 #1178 | [Vincent Demeester] Basic execution plugin module 📟 | 2020/12/01-12:25 #1242 | [Daniel Helfand] allow --prefix-name and --timeout to be overrode when using --last or --use options | 2020/12/01-12:25 #1250 | [Sunghoon Kang] Ignore --follow flag when TaskRun or PipelineRun is done | 2020/12/02-15:28 null | [SM43] Bumps Hub CLI Dependency | 2020/12/16-12:32 null | [Matt Moore] Hoist an ActivityTimeout option. | 2020/12/16-18:26 null | [Pradeep Kumar] bump pipeline and triggers dep | 2020/12/17-07:47 null | [Daniel Helfand] remove --check shorthand and add global flags to version cmd | 2020/12/17-08:59 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1240
This pull request moves where
--prefix-nameand--timeoutoptions are set in order to allow these values to be set when used with--lastor--use-taskrunor--use-pipelinerunoptions.Submitter Checklist
make checkmake generatedRelease Notes