Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-headers flag to tkn clustertriggerbinding list command #1243

Merged
merged 1 commit into from
Nov 16, 2020
Merged

Add --no-headers flag to tkn clustertriggerbinding list command #1243

merged 1 commit into from
Nov 16, 2020

Conversation

pratikjagrut
Copy link
Contributor

Changes

This PR adds support for --no-headers flag to tkn clustertriggerbinding list command as requested in issue #799.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add support for --no-headers flag to tkn clustertriggerbinding list.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 10, 2020
@tekton-robot
Copy link
Contributor

Hi @pratikjagrut. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 10, 2020
@pradeepitm12
Copy link
Contributor

/ok-to-test

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2020
@pratikjagrut
Copy link
Contributor Author

/test pull-tekton-cli-integration-tests
/test pull-tekton-cli-integration-tests-0_10

@pradeepitm12
Copy link
Contributor

/retest

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 12, 2020
@pratikjagrut
Add --no-headers flag to tkn clustertriggerbinding list command
ecae3df 
Sample output:
-------------------------------------------
tkn clustertriggerbinding list --no-headers
pipeline-clusterbinding-0   3 seconds ago
pipeline-clusterbinding-1   3 seconds ago
-------------------------------------------
@pratikjagrut pratikjagrut force-pushed the no-headers-ClusterTriggerBinding branch from dadbe32 to ecae3df Compare November 15, 2020 08:36
@pratikjagrut
Copy link
Contributor Author

PR Squashed.

@pradeepitm12
Copy link
Contributor

/test pull-tekton-cli-integration-tests

@pradeepitm12
Copy link
Contributor

pradeepitm12 commented Nov 16, 2020 •
edited
Loading

Hey @pratikjagrut 👋
Thanks for the PR, it's just the integration-test we need to check.
and this pr would be helpful to complete --no-headers flag with most of the commands

piyush-garg
piyush-garg approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@piyush-garg piyush-garg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, piyush-garg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,piyush-garg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@piyush-garg
Copy link
Contributor

/retest

@tekton-robot tekton-robot merged commit ec662f3 into tektoncd:master Nov 16, 2020
@pratikjagrut pratikjagrut mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand approved these changes

@piyush-garg piyush-garg piyush-garg approved these changes

@chmouel chmouel Awaiting requested review from chmouel

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pratikjagrut @tekton-robot @pradeepitm12 @piyush-garg @danielhelfand