Reproducible/deterministic bundles

[zregvart]

Changes

Sorts the bundle image layers according to the digest of the layer's content and adds the --ctime parameter to tkn bundle push to allow setting the created time in the bundle image config.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run the code checkers with make check
• Regenerate the manpages, docs and go formatting with make generated
• Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Tekton bundle images are reproducible with --ctime provided to tkn bundle push

Fixes #2132

[tekton-robot]

Hi @zregvart. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/ok-to-test

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[piyush-garg]

/lgtm

[chmouel]

can it be the default? do we need a flag for different behavior?

[zregvart]

can it be the default? do we need a flag for different behavior?

@chmouel do you mean set the created time to a predefined constant (say 1970-01-01?) instead of current time? Should be easy to do, I'm guessing there was a reason to setting it to the current time previously and I didn't want to change that.

[vdemeester]

can it be the default? do we need a flag for different behavior?

@chmouel do you mean set the created time to a predefined constant (say 1970-01-01?) instead of current time? Should be easy to do, I'm guessing there was a reason to setting it to the current time previously and I didn't want to change that.

I think I tend to agree with @chmouel, we could have it enabled by default. tkn bundles is an experimental set of subcommands, so we can "break" usage a little bit (even if, in that case, it shouldn't really break anything).

[zregvart]

I created a followup in #2135