Fix triggertemplate describe command breaks backward compatibility #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisis to fix triggertemplate describe command, which broke the backward compatibility as the field has been changed to camel case in triggers 0.26.0 release, which has been reverted in 0.26.1 change to make the same and fix backward compatibility. Here we are also bumping to 0.26.1 triggers to fix the backward compatibility
tekton-robot
added
the
release-note
tekton-robot
added
the
size/L
vdemeester
approved these changes
Feb 12, 2024
tekton-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
piyush-garg
added a commit
that referenced
this pull request
Feb 13, 2024
#2239 | [Piyush Garg] Bump docs to latest v0.35.0 | 2024/02/08-03:17 #2226 | [Senjuti De] Refactored README.md file. | 2024/02/08-10:03 #2240 | [dependabot[bot]] Bump golang.org/x/term from 0.16.0 to 0.17.0 | 2024/02/08-21:07 #2241 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.55.2 to 1.56.0 in /tools | 2024/02/08-21:37 #2242 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.56.0 to 1.56.1 in /tools | 2024/02/12-04:57 #2244 | [Piyush Garg] Fix triggertemplate describe command breaks backward compatibility | 2024/02/12-17:51 Signed-off-by: Piyush Garg <pgarg@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thisis to fix triggertemplate describe command, which broke the backward compatibility as the field has been changed to camel case in triggers 0.26.0 release, which has been reverted in 0.26.1 change to make the same and fix backward compatibility.
Here we are also bumping to 0.26.1 triggers to fix the backward compatibility
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes