Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting a customrun on the basis of name #2362

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Deleting a customrun on the basis of name #2362

merged 1 commit into from
Aug 20, 2024

Conversation

Senjuti256
Copy link
Contributor

@Senjuti256 Senjuti256 commented Jul 22, 2024 •
edited
Loading

Added the delete.go and delete_test.go files for customruns to handle deletion of customruns based on name only.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add tkn customrun delete command.

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024
@tekton-robot
Copy link
Contributor

Hi @Senjuti256. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2024
@Senjuti256
Copy link
Contributor Author

@piyush-garg

vinamra28
vinamra28 reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

pkg/cmd/customrun/delete.go Outdated
@@ -0,0 +1,89 @@
// Copyright © 2023 The Tekton Authors.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright © 2023 The Tekton Authors.
// Copyright © 2024 The Tekton Authors.

pkg/cmd/customrun/delete.go Outdated
return nil
}

func deleteSingleCustomRun(cs *cli.Clients, namespace, crName string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we rename this to deleteCustomRun ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinamra28 made the modifications as per your suggestion

@tekton-robot tekton-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 22, 2024
@Senjuti256
Copy link
Contributor Author

/retest

piyush-garg
piyush-garg reviewed Jul 23, 2024
View reviewed changes
pkg/cmd/customrun/delete_test.go
@@ -0,0 +1,171 @@
package customrun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add header

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 30, 2024
piyush-garg
piyush-garg reviewed Jul 31, 2024
View reviewed changes
pkg/cmd/customrun/delete.go Outdated
return err
}

for _, crName := range crNames {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be after delete command, if err is not nil

@Senjuti256
Copy link
Contributor Author

/test pull-tekton-cli-integration-tests

1 similar comment
@Senjuti256
Copy link
Contributor Author

/test pull-tekton-cli-integration-tests

piyush-garg
piyush-garg reviewed Aug 13, 2024
View reviewed changes
pkg/cmd/customrun/delete.go
}

func deleteCustomRun(cs *cli.Clients, namespace, crName string) error {
err := cs.Dynamic.Resource(customrunGroupResource).Namespace(namespace).Delete(context.TODO(), crName, metav1.DeleteOptions{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we do a check also first whether it exists?

@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 14, 2024
@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-integration-tests

@piyush-garg
Copy link
Contributor

/retest

@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@vinamra28
Copy link
Member

/retest

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vinamra28

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2024
@piyush-garg
Copy link
Contributor

/test pull-tekton-cli-integration-tests

@tekton-robot tekton-robot merged commit 6dff5fa into tektoncd:main Aug 20, 2024
8 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 22, 2024
Merged
@piyush-garg piyush-garg mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-garg piyush-garg piyush-garg left review comments

@vinamra28 vinamra28 vinamra28 approved these changes

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@piyush-garg piyush-garg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Senjuti256 @tekton-robot @piyush-garg @vinamra28