Re-use printer for multiple elements #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some printers contain an internal state. The YAMLPrinter, for example, tracks how many objects have been printed. When it prints an object, and it is not the first one to be printed, it prints the YAML document separator, `---`. If a new printer is used when printing each object, then the YAMLPrinter always considers that it is printing the first object. This causes the YAML objects to be muddled together. This commit makes it so a printer is re-used when printing multiple objects. For conformity, this is also done when a single object is expected to be printed, e.g. get or describe. Fixes tektoncd#2091 Signed-off-by: Luiz Carvalho <lucarval@redhat.com>
tekton-robot
added
release-note
piyush-garg
reviewed
Aug 14, 2024
piyush-garg
reviewed
Aug 14, 2024
vinamra28
approved these changes
Aug 21, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some printers contain an internal state. The YAMLPrinter, for example, tracks how many objects have been printed. When it prints an object, and it is not the first one to be printed, it prints the YAML document separator,
---. If a new printer is used when printing each object, then the YAMLPrinter always considers that it is printing the first object. This causes the YAML objects to be muddled together.This commit makes it so a printer is re-used when printing multiple objects. For conformity, this is also done when a single object is expected to be printed, e.g. get or describe.
Fixes #2091
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes