Remove hardcoded golangci-lint and go version #2386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will remove hardcoded versions of golangci-lint and go in Makefile and release pipeline, instead detect them from go.mod files This will eliminate the need to update them during release and also CI will run the latest golangci-lint version
tekton-robot
added
release-note
SKip type conversion golint warning G115 as it is breaking the CI
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vinamra28
added a commit
that referenced
this pull request
Sep 10, 2024
#2380 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.60.1 to 1.60.2 in /tools | 2024/08/22-08:46 #2382 | [Piyush Garg] Move to goreleaser v2 | 2024/08/22-12:00 #2383 | [Piyush Garg] Update docs for 0.38.0 release | 2024/08/23-12:10 #2384 | [dependabot[bot]] Bump github.com/golangci/golangci-lint from 1.60.2 to 1.60.3 in /tools | 2024/08/23-16:24 #2385 | [dependabot[bot]] Bump github.com/tektoncd/pipeline from 0.62.1 to 0.62.2 | 2024/08/23-17:18 #2387 | [Piyush Garg] Fix ubuntu launchpad build | 2024/08/26-09:12 #2386 | [Piyush Garg] Remove hardcoded golangci-lint and go version | 2024/08/26-09:46 #2386 | [Piyush Garg] Fix golint error | 2024/08/26-09:46 #2389 | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2024/08/29-03:27 #2390 | [Senjuti De] Refactored delete.go file for customrun | 2024/08/29-07:49 null | [Piyush Garg] Bump tektoncd/pipeline to v0.62.3 | 2024/09/04-05:09 null | [dependabot[bot]] Bump github.com/tektoncd/triggers from 0.29.0 to 0.29.1 | 2024/09/05-12:19 null | [dependabot[bot]] Bump the go-docker-dependencies group with 2 updates | 2024/09/10-10:39 Signed-off-by: vinamra28 <vinjain@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will remove hardcoded versions of golangci-lint and go in Makefile and release pipeline, instead detect them from go.mod files
This will eliminate the need to update them during release and also CI will run the latest golangci-lint version
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes