Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add triggertemplate list #532

Merged
merged 1 commit into from
Dec 23, 2019
Merged

Add triggertemplate list #532

merged 1 commit into from
Dec 23, 2019

Conversation

piyush-garg
Copy link
Contributor

@piyush-garg piyush-garg commented Dec 18, 2019 •
edited
Loading

This will add the trigger client to the cli and
add the subcommand triggertemplate to the tkn cli

This will add the list or ls command to triggertemplate
group

Add tests and docs

Part of #530

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add triggertemplate list command

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 18, 2019
@piyush-garg
Copy link
Contributor Author

/cc @vdemeester @chmouel @pradeepitm12 @hrishin

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/triggertemplate/list.go Do not exist 76.9%
pkg/cmd/triggertemplate/triggertemplate.go Do not exist 100.0%

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/triggertemplate/list.go Do not exist 78.9%
pkg/cmd/triggertemplate/triggertemplate.go Do not exist 100.0%

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-cli-unit-tests

hrishin
hrishin reviewed Dec 19, 2019
View reviewed changes
Copy link
Member

@hrishin hrishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

pkg/cmd/triggertemplate/list.go Outdated Show resolved Hide resolved
@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2019
@pradeepitm12
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/triggertemplate/list.go Do not exist 78.9%
pkg/cmd/triggertemplate/triggertemplate.go Do not exist 100.0%

@piyush-garg
Copy link
Contributor Author

/test pull-tekton-cli-unit-tests

danielhelfand
danielhelfand reviewed Dec 20, 2019
View reviewed changes
Copy link
Member

@danielhelfand danielhelfand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments. Otherwise 👍

pkg/cmd/triggertemplate/list.go Outdated Show resolved Hide resolved
pkg/cmd/triggertemplate/list.go Outdated Show resolved Hide resolved
pkg/cmd/triggertemplate/list.go Outdated Show resolved Hide resolved
pkg/cmd/triggertemplate/list.go Outdated Show resolved Hide resolved
pkg/cmd/triggertemplate/list_test.go Show resolved Hide resolved
@piyush-garg
Add triggertemplate list
d0a70e1 
This will add the trigger client to the cli and
add the subcommand triggertemplate to the tkn cli

This will add the list or ls command to triggertemplate
group

Add tests and docs

Part of tektoncd#530
@piyush-garg
Copy link
Contributor Author

@danielhelfand Thank you for the review. I have addressed your comments.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, pradeepitm12

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/triggertemplate/list.go Do not exist 85.7%
pkg/cmd/triggertemplate/triggertemplate.go Do not exist 100.0%

@pradeepitm12
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2019
@tekton-robot tekton-robot merged commit 89e99a4 into tektoncd:master Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrishin hrishin hrishin left review comments

@pradeepitm12 pradeepitm12 pradeepitm12 approved these changes

@danielhelfand danielhelfand danielhelfand approved these changes

@sthaha sthaha Awaiting requested review from sthaha

@chmouel chmouel Awaiting requested review from chmouel

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@pradeepitm12 pradeepitm12

@hrishin hrishin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@piyush-garg @tekton-robot @pradeepitm12 @hrishin @danielhelfand @googlebot