Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ./hack/tools.go instead of dummy_test.go ⚓ #537

Merged
merged 1 commit into from
Dec 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ require (
github.com/imdario/mergo v0.3.7 // indirect
github.com/jonboulle/clockwork v0.1.1-0.20190114141812-62fb9bc030d1
github.com/json-iterator/go v0.0.0-20180612202835-f2b4162afba3 // indirect
github.com/kr/pty v1.1.8 // indirect
github.com/markbates/inflect v1.0.4 // indirect
github.com/mattbaird/jsonpatch v0.0.0-20171005235357-81af80346b1a // indirect
github.com/mattn/go-isatty v0.0.9 // indirect
Expand All @@ -36,13 +35,12 @@ require (
github.com/spf13/pflag v1.0.3
github.com/stretchr/testify v1.4.0
github.com/tektoncd/pipeline v0.9.2
github.com/tektoncd/plumbing v0.0.0-20191114095731-51c53a31e779
github.com/tektoncd/plumbing v0.0.0-20191218171343-56a836c50336
go.opencensus.io v0.22.1 // indirect
golang.org/x/crypto v0.0.0-20190923035154-9ee001bba392 // indirect
golang.org/x/net v0.0.0-20190923162816-aa69164e4478 // indirect
golang.org/x/sync v0.0.0-20190911185100-cd5d95a43a6e // indirect
golang.org/x/sys v0.0.0-20190924154521-2837fb4f24fe // indirect
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7 // indirect
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect
gopkg.in/inf.v0 v0.9.1 // indirect
k8s.io/api v0.0.0-20191004102255-dacd7df5a50b
Expand Down
37 changes: 35 additions & 2 deletions go.sum

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions hack/tools.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
// +build tools

package tools

import (
_ "github.com/tektoncd/plumbing/scripts"
)
6 changes: 2 additions & 4 deletions test/dummy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.

package pkg
package test

import (
"testing"

_ "github.com/tektoncd/plumbing/scripts"
)

func TestDummy(t *testing.T) {
t.Log("This is required to make sure we get tektoncd/plumbing in the repository, folder vendor")
t.Log("Do nothing for now")
}
22 changes: 17 additions & 5 deletions vendor/github.com/tektoncd/plumbing/scripts/library.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 30 additions & 9 deletions vendor/github.com/tektoncd/plumbing/scripts/presubmit-tests.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ github.com/tektoncd/pipeline/pkg/substitution
github.com/tektoncd/pipeline/pkg/system
github.com/tektoncd/pipeline/test
github.com/tektoncd/pipeline/test/builder
# github.com/tektoncd/plumbing v0.0.0-20191114095731-51c53a31e779
# github.com/tektoncd/plumbing v0.0.0-20191218171343-56a836c50336
github.com/tektoncd/plumbing/scripts
# go.opencensus.io v0.22.1
go.opencensus.io
Expand Down