Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hashicorp/golang-lru #558

Merged
merged 1 commit into from
Dec 28, 2019
Merged

Conversation

piyush-garg
Copy link
Contributor

This will bump the dependencie to have the go.mod fix
helping to have proper license file

Right now the current local system golang version
was getting added to license-file everytime
during development. this bump will fix that

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

This will bump the dependencie to have the go.mod fix
helping to have proper license file

Right now the current local system golang version
was getting added to license-file everytime
during development. this bump will fix that
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 27, 2019
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
third_party/VENDOR-LICENSE/github.com/hashicorp/golang-lru/lru.go Do not exist 83.6%
third_party/VENDOR-LICENSE/github.com/hashicorp/golang-lru/simplelru/lru.go Do not exist 88.4%

@chmouel
Copy link
Member

chmouel commented Dec 28, 2019

@vdemeester coverage report on third_party? 🤔

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 28, 2019
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2019
@tekton-robot tekton-robot merged commit ec3cb7a into tektoncd:master Dec 28, 2019
@vdemeester
Copy link
Member

@vdemeester coverage report on third_party? thinking

/lgtm
/approve

Damn it… something to fix in 2020 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants