Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tkn task start -f With Remote Files #583

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Add tkn task start -f With Remote Files #583

merged 1 commit into from
Jan 9, 2020

Conversation

danielhelfand
Copy link
Member

Closes #557

This pull request adds the ability to start a taskrun based on a task definition that does not exist in a namespace from a remote file definition. As of now, it only supports local files.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

Release Notes

Allow tkn task start -f to work with remote files

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 9, 2020
@chmouel
Copy link
Member

chmouel commented Jan 9, 2020

/lgtm
/approve

Thanks 👍🏼🔥

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmouel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2020
@tekton-robot tekton-robot merged commit 32662c8 into tektoncd:master Jan 9, 2020
@danielhelfand danielhelfand deleted the task_start_remote branch February 10, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: tkn task start -f With Remote File
4 participants