Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add colouring for steps status 🎨 #595

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Add colouring for steps status 🎨 #595

merged 1 commit into from
Jan 13, 2020

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jan 13, 2020 •
edited
Loading

Changes

Steps status is coloured now 🌈 🎨

image

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

release-note

@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 13, 2020
@chmouel chmouel changed the title Add colouring to steps status too Add colouring for steps status 🎨 Jan 13, 2020
danielhelfand
danielhelfand reviewed Jan 13, 2020
View reviewed changes
pkg/formatted/k8s.go Outdated Show resolved Hide resolved
@chmouel
Add colouring to steps status too
2c5c5f0 
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@chmouel
Copy link
Member Author

chmouel commented Jan 13, 2020

How come the tests pass on my laptop 🤔

image

@chmouel
Copy link
Member Author

chmouel commented Jan 13, 2020

/retest

vdemeester
vdemeester approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 7b22297 into tektoncd:master Jan 13, 2020
@chmouel chmouel deleted the color-status-condition-2 branch June 27, 2021 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand approved these changes

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@sthaha sthaha Awaiting requested review from sthaha

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chmouel @tekton-robot @vdemeester @danielhelfand @googlebot