Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tkn clustertask start Subcommand #598

Merged
merged 1 commit into from
Jan 14, 2020
Merged

Add tkn clustertask start Subcommand #598

merged 1 commit into from
Jan 14, 2020

Conversation

danielhelfand
Copy link
Member

Closes #519

This pull request adds the ability to start a clustertask via tkn. It follows a very similar pattern to tkn task start with the major differences being that the --filename option is not supported for clustertasks and the kind property must be set to specify the taskrun is for a clustertask, not the default of a namespaced task.

Submitter Checklist

  • Includes tests (if functionality changed/added)
  • Includes docs (if user facing)
  • Regenerate the manpages and docs with make docs and make man if needed.
  • Run the code checkers with make check
  • Commit messages follow commit message best practices

Release Notes

Add tkn clustertask start subcommand

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 14, 2020
@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-unit-tests

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/start.go Do not exist 92.6%
pkg/helper/task/tasklastrun.go 92.3% 86.7% -5.6

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/cmd/clustertask/start.go Do not exist 92.6%

@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-unit-tests

2 similar comments
@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-unit-tests

@danielhelfand
Copy link
Member Author

/test pull-tekton-cli-unit-tests

@tekton-robot tekton-robot merged commit 010bc97 into tektoncd:master Jan 14, 2020
@danielhelfand danielhelfand deleted the typo branch January 21, 2020 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add command to start clustertasks similar to tasks
4 participants