Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping flaky interactive tests 🧨 #616

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Skipping flaky interactive tests 🧨 #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pkg/cmd/pipeline/logs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,8 @@ func TestPipelineLog(t *testing.T) {
}

func TestPipelineLog_Interactive(t *testing.T) {
t.Skip("Skipping this test due of some flakeyness")
t.Skip("Skipping due of flakiness")

clock := clockwork.NewFakeClock()

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Expand Down
1 change: 1 addition & 0 deletions pkg/cmd/pipeline/start_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,7 @@ func TestPipelineStart_ExecuteCommand(t *testing.T) {
}

func TestPipelineStart_Interactive(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Pipelines: []*v1alpha1.Pipeline{
Expand Down
24 changes: 24 additions & 0 deletions pkg/cmd/pipelineresource/create_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ func init() {
}

func TestPipelineResource_resource_noName(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
PipelineResources: []*v1alpha1.PipelineResource{
tb.PipelineResource("res", "namespace",
Expand Down Expand Up @@ -105,6 +107,7 @@ func TestPipelineResource_resource_noName(t *testing.T) {
}

func TestPipelineResource_resource_already_exist(t *testing.T) {
t.Skip("Skipping due of flakiness")
cs, _ := test.SeedTestData(t, pipelinetest.Data{
PipelineResources: []*v1alpha1.PipelineResource{
tb.PipelineResource("res", "namespace",
Expand Down Expand Up @@ -161,6 +164,7 @@ func TestPipelineResource_resource_already_exist(t *testing.T) {
}

func TestPipelineResource_allResourceType(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
Expand Down Expand Up @@ -270,6 +274,8 @@ func TestPipelineResource_allResourceType(t *testing.T) {
}

func TestPipelineResource_create_cloudEventResource(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -340,6 +346,8 @@ func TestPipelineResource_create_cloudEventResource(t *testing.T) {
}

func TestPipelineResource_create_clusterResource_secure_password_text(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -486,6 +494,8 @@ func TestPipelineResource_create_clusterResource_secure_password_text(t *testing
}

func TestPipelineResource_create_clusterResource_secure_token_text(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -636,6 +646,8 @@ func TestPipelineResource_create_clusterResource_secure_token_text(t *testing.T)
}

func TestPipelineResource_create_gitResource(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -733,6 +745,8 @@ func TestPipelineResource_create_gitResource(t *testing.T) {
}

func TestPipelineResource_create_imageResource(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -835,6 +849,8 @@ func TestPipelineResource_create_imageResource(t *testing.T) {
}

func TestPipelineResource_create_clusterResource_secure_password_secret(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -997,6 +1013,8 @@ func TestPipelineResource_create_clusterResource_secure_password_secret(t *testi
}

func TestPipelineResource_create_clusterResource_secure_token_secret(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -1171,6 +1189,8 @@ func TestPipelineResource_create_clusterResource_secure_token_secret(t *testing.
}

func TestPipelineResource_create_pullRequestResource(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -1300,6 +1320,8 @@ func TestPipelineResource_create_pullRequestResource(t *testing.T) {
}

func TestPipelineResource_create_gcsStorageResource(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down Expand Up @@ -1442,6 +1464,8 @@ func TestPipelineResource_create_gcsStorageResource(t *testing.T) {
}

func TestPipelineResource_create_buildGCSstorageResource(t *testing.T) {
t.Skip("Skipping due of flakiness")

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Namespaces: []*corev1.Namespace{
{
Expand Down
2 changes: 2 additions & 0 deletions pkg/cmd/task/logs_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,8 @@ func TestTaskLog(t *testing.T) {
}

func TestTaskLog2(t *testing.T) {
t.Skip("Skipping due of flakiness")

clock := clockwork.NewFakeClock()

cs, _ := test.SeedTestData(t, pipelinetest.Data{
Expand Down