Add emojis to pipeline/pipelinerun/task/taskrun describe #620
Conversation
tekton-robot
added
the
size/M
|
The following is the coverage report on pkg/.
|
| @@ -34,7 +34,7 @@ import ( | |||
| const describeTemplate = `{{decorate "bold" "Name"}}: {{ .PipelineName }} | |||
| {{decorate "bold" "Namespace"}}: {{ .Pipeline.Namespace }} | |||
|
|
|||
| {{decorate "underline bold" "Resources\n"}} | |||
| {{decorate "resources" ""}}{{decorate "underline bold" "Resources\n"}} | |||
There was a problem hiding this comment.
tried to do stuff like this :
{{ decorate "inputresources" "" | decorate "underline bold" "Input Resources\n"}}but I am getting the error message :
Error: template: Describe Task:4:33: executing "Describe Task" at <decorate>: wrong number of args for decorate: want 2 got 3
🤔
|
The following is the coverage report on pkg/.
|
|
The following is the coverage report on pkg/.
|
Not showing when we don't want colours (or not a real terminal). Add TestDecoration to test properly decorations Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
|
The following is the coverage report on pkg/.
|
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
approved
|
/retest failure was : |
| return fmt.Sprintf("📨 ") | ||
| case "outputresources": | ||
| return fmt.Sprintf("📡 ") | ||
| case "steps": |
There was a problem hiding this comment.
I didnt take the black feet version due of not showing very well on dark terminal... i guess those one works on dark and light background terminal....
There was a problem hiding this comment.
Oh yeah, no worries! More approving and wanted to mix it up.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danielhelfand, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not showing when we don't want colours (or not a real terminal).
The choice of emojis are fairly abritrary, I am open for suggestions :D
Some screenshots :
Pipeline
PipelineRun
Task
TaskRun