Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for k8.Condition #622

Merged
merged 1 commit into from
Jan 20, 2020
Merged

Add tests for k8.Condition #622

merged 1 commit into from
Jan 20, 2020

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Jan 17, 2020

Figured while refactoring this file that this part of the code wasn't tested, so
let's add some tests..

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 17, 2020
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/formatted/k8s.go 6.2% 81.2% 75.0

@chmouel chmouel force-pushed the add-conditions-unit-tests branch 2 times, most recently from b8c18ff to 480556f Compare January 17, 2020 10:06
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/formatted/k8s.go 6.2% 87.5% 81.2

@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/formatted/k8s.go 6.2% 100.0% 93.8

@chmouel
Copy link
Member Author

chmouel commented Jan 17, 2020

I wish we had #616 merged!

/retest

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
@chmouel
Add tests for k8.Condition
76605b6 
Figured while refactoring this file that this part of the code wasn't tested, so
let's add some tests..

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@tekton-robot
Copy link
Contributor

The following is the coverage report on pkg/.
Say /test pull-tekton-cli-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/formatted/k8s.go 28.6% 100.0% 71.4

vdemeester
vdemeester approved these changes Jan 20, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielhelfand,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot merged commit 8588d29 into tektoncd:master Jan 20, 2020
@chmouel chmouel deleted the add-conditions-unit-tests branch June 27, 2021 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhelfand danielhelfand danielhelfand approved these changes

@vdemeester vdemeester vdemeester approved these changes

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

Assignees

@vdemeester vdemeester

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chmouel @tekton-robot @vdemeester @danielhelfand @googlebot