Use golden package for unit test 🐐 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
vdemeester
force-pushed
the
task-golden
branch
from
6738f69
to
3be5b71
Compare
tekton-robot
added
size/XXL
|
What about a script or makefile target that would generate those golden files? |
Yeah it's the next step 😝 |
vdemeester
force-pushed
the
task-golden
branch
3 times, most recently
from
b970fdd
to
6194780
Compare
chmouel
reviewed
Jan 17, 2020
hack/update-golden.sh
Outdated
| @@ -0,0 +1,2 @@ | |||
| #!/usr/bin/env bash | |||
| go test $(go list -f '{{ .ImportPath }} {{ .TestImports }}' ./... | grep golden | awk '{print $1}' | tr '\n' ' ') -test.update-golden=true | |||
There was a problem hiding this comment.
can you add a comment on what it does? this look like cryptic to me 🙇
vdemeester
force-pushed
the
task-golden
branch
from
6194780
to
9ef51fe
Compare
|
/retest |
vdemeester
force-pushed
the
task-golden
branch
from
9ef51fe
to
7fb6df9
Compare
|
/lgtm Looking Good! |
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
This allow to remove the potential long expected output from the test code. See gotest.tools/v3/golden for documentation. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
Errors should be ignored when running this 👼 Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
vdemeester
force-pushed
the
task-golden
branch
from
7fb6df9
to
cd7c83e
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmouel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This allow to remove the potential long expected output from the test
code. See gotest.tools/v3/golden for documentation.
/cc @chmouel
Signed-off-by: Vincent Demeester vdemeest@redhat.com
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docsandmake manif needed.make checkSee the contribution guide
for more details.