Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repeated sentence. #636

Merged
merged 1 commit into from
Jan 31, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,16 @@ After installing tkn, create a link as kubectl-tkn
```shell
$ ln -s /usr/local/bin/tkn /usr/local/bin/kubectl-tkn
```

`kubectl` will find any binary named `kubectl-*` on your `PATH` and consider it as a plugin
ansky marked this conversation as resolved.
Show resolved Hide resolved

Run the following to confirm tkn is available as a plugin:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't thank this is needed isnt it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not technically needed, but I think it makes sense as a way to confirm it's available before running kubectl-tkn. Better to know it's set up correctly before running commands with it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run the following to confirm tkn is available as a plugin:
Run the following to confirm `tkn` is available as a plugin:

```shell
$ ./kubectl plugin list
/usr/local/bin/kubectl-tkn
$ kubectl plugin list
```

You should see the following after running kubectl plugin list if tkn is available as a plugin:
```shell
/usr/local/bin/kubectl-tkn
```
If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If the output above is shown, run kubectl-tkn to see the list of available tkn commands to run.
If the output above is shown, run `kubectl-tkn` to see the list of available `tkn` commands to run.


### Useful Commands

The following commands help you understand and effectively use the Tekton CLI:
Expand Down