New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor --dry-run Tests for tkn pipeline start To Use Golden File #657

Merged

tekton-robot merged 1 commit into tektoncd:master from danielhelfand:pipeline_start_goldent

Jan 29, 2020

Member

danielhelfand commented Jan 29, 2020 •

edited

Loading

Use golden file for --dry-run tests only. Add goldenFile boolean to test struct so golden file is only used for large output from tests.

Submitter Checklist

Includes tests (if functionality changed/added)
Includes docs (if user facing)
Regenerate the manpages and docs with make docs and make man if needed.
Run the code checkers with make check
Commit messages follow commit message best practices

Release Notes

N/A


          refactor --dry-run tests for tkn pipeline start

59bbf02

googlebot added the cla: yes label

tekton-robot requested review from chmouel and vdemeester

January 29, 2020 16:32

tekton-robot added the size/L label

Member

chmouel commented Jan 29, 2020

/lgtm

Looking Good! 🤙🏽

tekton-robot assigned chmouel

tekton-robot added the lgtm label

vdemeester approved these changes

View reviewed changes

Member

vdemeester left a comment

/lgtm

tekton-robot assigned vdemeester

tekton-robot added the approved label

piyush-garg approved these changes

View reviewed changes

Contributor

piyush-garg left a comment

/lgtm

tekton-robot assigned piyush-garg

Contributor

tekton-robot commented Jan 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piyush-garg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [piyush-garg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tekton-robot merged commit b5feaff into tektoncd:master

piyush-garg added a commit that referenced this pull request


          New version v0.7.0

bb492f7

#513 | [Daniel Helfand] update versions in README for 0.6.0 | 2019/12/12-02:36
#514 | [Chmouel Boudjnah] Add info in README about debian installs | 2019/12/12-04:27
#515 | [Chmouel Boudjnah] Change NFPM package name | 2019/12/12-04:44
#516 | [Chmouel Boudjnah] Fix install bash and zsh completion | 2019/12/13-04:55
#518 | [Chmouel Boudjnah] Tektoncd Release 0.9.2 | 2019/12/13-05:37
#508 | [16yuki0702] Making task logs interactive. | 2019/12/16-02:57
#517 | [Daniel Helfand] test for tkn task start --filename | 2019/12/16-03:11
#525 | [Jason Hall] Attempt to fix formatting of examples | 2019/12/18-09:07
#528 | [Chmouel Boudjnah] Set default to False for Show Logs on TaskRun and PipelineRun | 2019/12/18-10:11
#533 | [Daniel Helfand] show cancelled instead of failed for pr and tr desc | 2019/12/19-10:10
null | [Vincent Demeester] Switch to gotest.tools/v3 instead of testify 🐺 | 2019/12/20-04:44
null | [Vincent Demeester] Use ./hack/tools.go instead of dummy_test.go ⚓ | 2019/12/20-05:14
null | [Vincent Demeester] Bump github.com/imdario/mergo to 0.3.8 | 2019/12/20-05:33
null | [Chmouel Boudjnah] Add piyush as an OWNER 🕺 | 2019/12/20-08:04
null | [Piyush Garg] Add triggertemplate list | 2019/12/23-00:08
null | [Piyush Garg] Fix CI | 2019/12/23-10:09
null | [Daniel Helfand] remove namespace check for clustertask | 2019/12/23-10:38
null | [Piyush Garg] Add triggerbinding list | 2019/12/23-14:36
null | [Piyush Garg] Add eventlistener list | 2019/12/26-06:12
null | [Pradeep Kumar] Adds command to delete triggertemplate | 2019/12/26-21:38
null | [Daniel Helfand] converting taskrun desc tests to use step state test builder | 2019/12/27-00:24
null | [Pradeep Kumar] change test name | 2019/12/27-09:20
null | [Pradeep Kumar] Add command to delete triggerbinding | 2019/12/27-11:11
null | [Piyush Garg] Bump hashicorp/golang-lru | 2019/12/28-04:01
null | [Khurram Baig] Add Command to Remove EventListener | 2020/01/02-08:53
null | [Daniel Helfand] error message for using --last with tkn task start -f | 2020/01/02-09:39
null | [16yuki0702] Refactoring pipeline log tests. | 2020/01/02-09:51
null | [Daniel Helfand] updating release notes for CLI | 2020/01/06-07:22
null | [Daniel Helfand] add choco package to README and minor edits | 2020/01/06-08:17
null | [Piyush Garg] Refactor triggertemplate list test | 2020/01/07-00:29
null | [Chmouel Boudjnah] Syncronize cobra to latest | 2020/01/07-09:01
null | [Scott] Update all delete commands to support multiple arguments | 2020/01/08-13:02
null | [16yuki0702] Refactoring pipeline start tests. | 2020/01/09-07:56
null | [Daniel Helfand] add tkn task start -f with remote files | 2020/01/09-10:01
null | [Scott] Refactor delete command code to make a bit more DRY | 2020/01/10-02:49
null | [Daniel Helfand] add nil check for pr desc taskrun sorting | 2020/01/10-07:12
null | [Chmouel Boudjnah] Add coloured status condition | 2020/01/10-15:20
null | [Chmouel Boudjnah] Add colouring to steps status too | 2020/01/13-10:29
null | [Daniel Helfand] correct tkn task start typo | 2020/01/13-14:18
null | [Daniel Helfand] add tkn clustertask start | 2020/01/14-08:29
null | [Daniel Helfand] remove second taskrun from pr desc test | 2020/01/15-00:01
null | [Chmouel Boudjnah] Subtle cosmetics changes to describe command | 2020/01/15-09:58
null | [Chmouel Boudjnah] Show fluffy decorations only when we can or when the user wants it | 2020/01/15-09:58
null | [Chmouel Boudjnah] Fix release tarball version to remove the v at first | 2020/01/15-11:38
null | [Chmouel Boudjnah] Add Namespace to tkn pipeline desc | 2020/01/15-14:57
null | [Chmouel Boudjnah] Fix to auto select the first pipeline when only one is available | 2020/01/16-02:45
null | [Chmouel Boudjnah] Disable TestPipelineLog_Interactive | 2020/01/16-02:45
null | [Daniel Helfand] tkn create command | 2020/01/16-03:32
null | [Chmouel Boudjnah] Do not show bracket when showing the RunAfter.Tasks in Pipeline desc | 2020/01/16-04:07
null | [Chmouel Boudjnah] Set no colours automatically when not running with a tty or a pipe | 2020/01/16-16:33
null | [Chmouel Boudjnah] Skipping flakey interactive tests | 2020/01/17-07:42
null | [Vincent Demeester] Use golden package for unit test for Task 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test in TaskRun 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for Pipeline 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for PipelineRun 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for Condition 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for ClusterTask 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for TriggerBinding 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for TriggerTemplate 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for EventListener 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Use golden package for unit test for PipelineResource 🐐 | 2020/01/19-15:20
null | [Vincent Demeester] Add `test-unit-update-golden` target to update golden files 🐟 | 2020/01/19-15:20
null | [Chmouel Boudjnah] generate steps name when none has been provided | 2020/01/20-00:02
null | [Chmouel Boudjnah] Add tests for k8.Condition | 2020/01/20-04:27
null | [Daniel Helfand] add tkn clustertask desc | 2020/01/20-11:11
null | [Chmouel Boudjnah] Add emojis to pipeline/pipelinerun/task/taskrun describe | 2020/01/22-08:40
null | [Chmouel Boudjnah] tkn clustertask describe zsh completion is broken | 2020/01/22-12:21
null | [Chmouel Boudjnah] Add emojis support for tkn clustertask describe command | 2020/01/22-12:44
null | [Piyush Garg] Return error inspite of nil | 2020/01/23-08:28
null | [Chmouel Boudjnah] Implement output for pipeline describe | 2020/01/27-03:07
null | [Daniel Helfand] sort steps for tr desc by StartedAt | 2020/01/28-03:57
null | [Scott] Add flag to task and pipeline to only delete related resources | 2020/01/28-08:47
null | [Vincent Demeester] Remove 🏻 from the step emoji 🍲 | 2020/01/28-10:00
null | [Chmouel Boudjnah] Refactor a bit custom output function | 2020/01/28-10:57
null | [Chmouel Boudjnah] Fix PipelineResource custom output | 2020/01/28-10:57
null | [Chmouel Boudjnah] Fix PipelineRuns custom output | 2020/01/28-10:57
#648 | [Chmouel Boudjnah] Fix Task custom output | 2020/01/28-10:57
#648 | [Chmouel Boudjnah] Fix TaskRuns custom output | 2020/01/28-10:57
#648 | [Chmouel Boudjnah] Fix ClusterTask custom output | 2020/01/28-10:57
#643 | [Daniel Helfand] --dry-run option for tkn pipeline start | 2020/01/29-02:50
#653 | [Chmouel Boudjnah] Minor wording fixes on the RELEASE_PROCESS document | 2020/01/29-04:26
#656 | [Vincent Demeester] Use gotest.tools assert package instead of testify 🍵 | 2020/01/29-05:16
#657 | [Daniel Helfand] refactor --dry-run tests for tkn pipeline start | 2020/01/29-10:55
#661 | [Chmouel Boudjnah] Fix output=name for pipeline list | 2020/01/30-10:08
#658 | [Piyush Garg] Bump tektoncd/pipeline and tektoncd/triggers | 2020/01/31-03:37
null | [Piyush Garg] Fix workspace not getting copied with --last | 2020/01/31-04:34
null | [16yuki0702] This fixes #639 | 2020/01/31-06:46
null | [ansky] Remove extra empty lines | 2020/01/31-10:30
null | [Daniel Helfand] remove tkn create | 2020/01/31-10:52
null | [Daniel Helfand] add --dry-run option for tkn task start | 2020/02/03-00:59
null | [Daniel Helfand] add --dry-run option for tkn ct start | 2020/02/03-01:17
null | [16yuki0702] Fix overriding GenerateName on taskrun. | 2020/02/03-06:23

Signed-off-by: Piyush Garg <piyushgarg001@gmail.com>

danielhelfand deleted the pipeline_start_goldent branch

February 10, 2020 16:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cla: yes lgtm size/L