Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEP-0007: Conditions Beta - further discussion and status update #167

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

jerop
Copy link
Member

@jerop jerop commented Aug 5, 2020

Added Conditions Beta TEP in #159

Let's discuss the TEP further and explore making it implementable per the TEP workflow

cc pipeline owners: @vdemeester @afrittoli @pritidesai @bobcatfish @sbwsg @imjasonh @dibyom @dlorenc

Added Conditions Beta TEP in tektoncd#159

Let's discuss the TEP further and explore making it implementable as per
the TEP workflow.
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 5, 2020
@vdemeester
Copy link
Member

Added Conditions Beta TEP in #159

Let's discuss the TEP further and explore making it implementable per the TEP workflow

cc pipeline owners: @vdemeester @afrittoli @pritidesai @bobcatfish @sbwsg @imjasonh @dibyom @dlorenc

you can do @tektoncd/core-maintainers too 😛

@bobcatfish
Copy link
Contributor

I am 👍 for this but also I was part of this design so I'm very biased :D

Could some other OWNERs weigh in on whether they think we are ready to make this implementable, @vdemeester @pritidesai ( @tektoncd/core-maintainers :D )

@ghost
Copy link

ghost commented Aug 6, 2020

👍 from me too!

@pritidesai
Copy link
Member

👍 from me three 😊

@pritidesai
Copy link
Member

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2020
@dibyom
Copy link
Member

dibyom commented Aug 7, 2020

Let's ship it!
/lgtm

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/meow

@tekton-robot
Copy link
Contributor

@vdemeester: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2020
@tekton-robot tekton-robot merged commit 52e3913 into tektoncd:master Aug 7, 2020
@jerop jerop deleted the conditions-beta-implementable branch January 6, 2022 15:07
dlorenc pushed a commit to dlorenc/community that referenced this pull request Oct 27, 2022
Signed-off-by: kpk47 <kkris@google.com>

Signed-off-by: kpk47 <kkris@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants